Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2300973002: NOT FOR LANDING Update FreeType to upstream 57a6733dcf7828fe3db9254edab33fda7c9f6a10. (Closed)

Created:
4 years, 3 months ago by drott
Modified:
3 years, 8 months ago
Reviewers:
bungeman-skia
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR LANDING Update FreeType to upstream 2.7.1 Update the local FreeType version that is statically linked for layout tests to 2.7.1. BUG=274030

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressing review comments, simplified top level config #

Patch Set 3 : Re-add BDF since fontconfig for cast_shell needs it #

Patch Set 4 : Update to latest on 12/22 including Variation fixes 7209110345206, 992e40e9d9afb #

Patch Set 5 : experimentally change rendering mode #

Patch Set 6 : Experimentally changing FreeType render mode #

Patch Set 7 : Rebase, see trybot results again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -288 lines) Patch
M DEPS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M build/linux/BUILD.gn View 1 1 chunk +7 lines, -16 lines 0 comments Download
M third_party/freetype2/BUILD.gn View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M third_party/freetype2/README.chromium View 1 2 1 chunk +31 lines, -38 lines 0 comments Download
D third_party/freetype2/freetype2.patch View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/freetype2/include/ftconfig.h View 14 chunks +136 lines, -180 lines 0 comments Download
M third_party/freetype2/include/ftmodule.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/freetype2/patches/freetype2_symbols_visibility.patch View 1 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 46 (40 generated)
bungeman-skia
Just some build comments as things to keep in mind. If Chromium doesn't need to ...
4 years, 3 months ago (2016-09-01 15:08:33 UTC) #6
drott
Addressing review comments, simplified top level config
3 years, 12 months ago (2016-12-21 13:53:06 UTC) #7
drott
Not ready for review yet, I need to ensure that we keep the previous rendering ...
3 years, 12 months ago (2016-12-22 13:39:12 UTC) #26
drott
experimentally change rendering mode
3 years, 11 months ago (2016-12-28 13:02:01 UTC) #27
drott
Experimentally changing FreeType render mode
3 years, 11 months ago (2016-12-28 15:49:12 UTC) #32
drott
3 years, 11 months ago (2017-01-05 14:54:20 UTC) #37
Rebase, see trybot results again

Powered by Google App Engine
This is Rietveld 408576698