Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2300963003: GN: add extra_ldflags (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add extra_ldflags This is mostly just handy for hacking around while building out other GN features. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300963003 Committed: https://skia.googlesource.com/skia/+/bb35a6aa2d4033a7aa50355558152fe647bc6fa5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gn/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 3 months ago (2016-09-01 15:40:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300963003/1
4 years, 3 months ago (2016-09-01 15:40:22 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-01 15:40:24 UTC) #6
jcgregorio
lgtm
4 years, 3 months ago (2016-09-01 15:43:23 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 16:15:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bb35a6aa2d4033a7aa50355558152fe647bc6fa5

Powered by Google App Engine
This is Rietveld 408576698