Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2300933002: Add step to show goma stat in goma module (Closed)

Created:
4 years, 3 months ago by tikuta
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M scripts/slave/recipe_modules/goma/api.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/linux.json View 1 chunk +12 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/mac.json View 1 chunk +12 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json View 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/win.json View 1 chunk +12 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
tikuta
4 years, 3 months ago (2016-09-01 07:59:36 UTC) #2
shinyak
lgtm BUG=544330 ?
4 years, 3 months ago (2016-09-01 08:09:33 UTC) #3
tikuta
On 2016/09/01 08:09:33, shinyak wrote: > lgtm > > BUG=544330 ? Done
4 years, 3 months ago (2016-09-01 08:10:22 UTC) #5
shinyak
(Ah, the context is here...) https://chromereviews.googleplex.com/494557014/
4 years, 3 months ago (2016-09-01 08:12:50 UTC) #6
Paweł Hajdan Jr.
LGTM
4 years, 3 months ago (2016-09-01 09:43:49 UTC) #7
ukai
lgtm
4 years, 3 months ago (2016-09-02 04:55:04 UTC) #8
Yoshisato Yanagisawa
lgtm
4 years, 3 months ago (2016-09-02 04:55:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300933002/1
4 years, 3 months ago (2016-09-02 05:11:16 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/a74f612ef99de4de59320e5f390e16bf6934cf88
4 years, 3 months ago (2016-09-02 05:14:52 UTC) #17
tandrii(chromium)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2303333002/ by tandrii@chromium.org. ...
4 years, 3 months ago (2016-09-02 14:56:20 UTC) #18
tandrii(chromium)
my bad, revert wasn't warranted.
4 years, 3 months ago (2016-09-02 15:12:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300933002/1
4 years, 3 months ago (2016-09-02 15:15:47 UTC) #24
tandrii(chromium)
Re-landing.
4 years, 3 months ago (2016-09-02 15:15:51 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 15:19:47 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/5036526e4c165e54379d...

Powered by Google App Engine
This is Rietveld 408576698