Process Custom Elements in post-order.

Source/core/dom/CustomElement.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 75 matching lines @@
 bool CustomElement::isCustomTagName(const AtomicString& localName)
 {
     return isValidTypeName(localName);
 }
 
 void CustomElement::define(Element* element, PassRefPtr<CustomElementDefinition> passDefinition)
 {
     RefPtr<CustomElementDefinition> definition(passDefinition);
     element->setCustomElementState(Element::Defined);
     definitions().add(element, definition);
-    CustomElementCallbackScheduler::scheduleCreatedCallback(definition->callbacks(), element);
+    if (!elementsBeingParsed().contains(element))

[dglazkov, 2013/08/13 16:22:06]

I am trying to figure out why we need this check and the hashset. Can you
explain this a bit more?

+        CustomElementCallbackScheduler::scheduleCreatedCallback(definition->callbacks(), element);
 }
 
 CustomElementDefinition* CustomElement::definitionFor(Element* element)
 {
     return definitions().get(element);
 }
 
+void CustomElement::finishedParsingChildren(Element* element)
+{
+    switch (element->customElementState()) {
+    case Node::NotCustomElement:
+    case Node::Upgraded:
+        ASSERT_NOT_REACHED();
+        return;
+
+    case Node::UpgradeCandidate:
+        CustomElementUpgradeCandidateMap::elementFinishedParsingChildren(element);
+        setFinishedParsing(element);
+        return;
+
+    case Node::Defined:
+        setFinishedParsing(element);
+        CustomElementCallbackScheduler::scheduleCreatedCallback(definitionFor(element)->callbacks(), element);
+        return;
+    }
+}
+
 void CustomElement::attributeDidChange(Element* element, const AtomicString& name, const AtomicString& oldValue, const AtomicString& newValue)
 {
     ASSERT(element->customElementState() == Element::Upgraded);
     CustomElementCallbackScheduler::scheduleAttributeChangedCallback(definitions().get(element)->callbacks(), element, name, oldValue, newValue);
 }
 
 void CustomElement::didEnterDocument(Element* element, Document* document)
 {
     ASSERT(element->customElementState() == Element::Upgraded);
     if (!document->defaultView())
@@ skipping 11 matching lines @@
 
 void CustomElement::wasDestroyed(Element* element)
 {
     switch (element->customElementState()) {
     case Element::NotCustomElement:
         ASSERT_NOT_REACHED();
         break;
 
     case Element::UpgradeCandidate:
         CustomElementUpgradeCandidateMap::elementWasDestroyed(element);
+        elementsBeingParsed().remove(element);
         break;
 
     case Element::Defined:
+        elementsBeingParsed().remove(element);
+        definitions().remove(element);
+        break;
+
     case Element::Upgraded:
         definitions().remove(element);
         break;
     }
 }
 
 void CustomElement::DefinitionMap::add(Element* element, PassRefPtr<CustomElementDefinition> definition)
 {
     ASSERT(definition.get());
     DefinitionMap::ElementDefinitionHashMap::AddResult result = m_definitions.add(element, definition);
@@ skipping 11 matching lines @@
     ASSERT(it != m_definitions.end());
     return it->value.get();
 }
 
 CustomElement::DefinitionMap& CustomElement::definitions()
 {
     DEFINE_STATIC_LOCAL(DefinitionMap, map, ());
     return map;
 }
 
+CustomElement::ElementSet& CustomElement::elementsBeingParsed()
+{
+    DEFINE_STATIC_LOCAL(ElementSet, set, ());
+    return set;
+}
+
+void CustomElement::setBeingParsed(Element* element)
+{
+    ElementSet::AddResult result = elementsBeingParsed().add(element);
+    ASSERT(result.isNewEntry);
+}
+
+void CustomElement::setFinishedParsing(Element* element)
+{
+    ElementSet::iterator it = elementsBeingParsed().find(element);
+    ASSERT(it != elementsBeingParsed().end());
+    elementsBeingParsed().remove(it);
+}
+
 } // namespace WebCore