Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2300893003: Try UnicodeFromCharCode even with PDFFONT_SYMBOLIC (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix CPDF_CIDFont::GlyphFromCharCode for fonts flagged with PDFFONT_SYMBOLIC UnicodeFromCharCode should be tried even if the font is flagged as PDFFONT_SYMBOLIC. The result should be checked in case it's empty. This fixes some corpus tests that were being incorrectly rendered, as well as the bug below. A deps change will be required before landing this CL. BUG=chromium:591303 Committed: https://pdfium.googlesource.com/pdfium/+/f4bf0b22d7fd04be99f05b89008598956cc4ded0

Patch Set 1 #

Patch Set 2 : Change DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
npm
This won't pass corpus tests, because they need to be fixed. PTAL
4 years, 3 months ago (2016-09-01 17:19:17 UTC) #3
dsinclair
lgtm once the DEPS change is included.
4 years, 3 months ago (2016-09-01 17:26:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300893003/20001
4 years, 3 months ago (2016-09-01 20:08:58 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:09:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/f4bf0b22d7fd04be99f05b89008598956cc4...

Powered by Google App Engine
This is Rietveld 408576698