Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ui/base/models/combobox_model.h

Issue 2300893002: Make notifier settings combobox a real combobox. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/message_center/views/notifier_settings_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/models/combobox_model.h
diff --git a/ui/base/models/combobox_model.h b/ui/base/models/combobox_model.h
index 361810989f8b096bce3ee7ebda8b9f1c00c50b86..2fcd7b69029beb56a6c1040ecbc5272c6562189a 100644
--- a/ui/base/models/combobox_model.h
+++ b/ui/base/models/combobox_model.h
@@ -15,6 +15,8 @@ class ComboboxModelObserver;
// A data model for a combo box.
class UI_BASE_EXPORT ComboboxModel {
public:
+ virtual ~ComboboxModel() {}
+
// Returns the number of items in the combo box.
virtual int GetItemCount() const = 0;
@@ -35,9 +37,6 @@ class UI_BASE_EXPORT ComboboxModel {
// Adds/removes an observer. Override if model supports mutation.
virtual void AddObserver(ComboboxModelObserver* observer) {}
virtual void RemoveObserver(ComboboxModelObserver* observer) {}
-
- protected:
- virtual ~ComboboxModel() {}
};
} // namespace ui
« no previous file with comments | « no previous file | ui/message_center/views/notifier_settings_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698