Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2300883002: Revert of Allow component-updated Flash to override the placeholder fake Flash even if (Closed)

Created:
4 years, 3 months ago by fgorski
Modified:
4 years, 3 months ago
Reviewers:
waffles, Will Harris
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow component-updated Flash to override the placeholder fake Flash even if (patchset #2 id:20001 of https://codereview.chromium.org/2298343002/ ) Reason for revert: missing ; Original issue's description: > Allow component-updated Flash to override the placeholder fake Flash even if > the version is lower. > > BUG=642323 > > Committed: https://crrev.com/30f12cd92e58dddfd196e72356aea5abefacaf4d > Cr-Commit-Position: refs/heads/master@{#415781} TBR=wfh@chromium.org,waffles@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642323 Committed: https://crrev.com/e3dbbe45a1f8e74a80e520c2e74a8e47b84d0d72 Cr-Commit-Position: refs/heads/master@{#415794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fgorski
Created Revert of Allow component-updated Flash to override the placeholder fake Flash even if
4 years, 3 months ago (2016-08-31 23:06:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300883002/1
4 years, 3 months ago (2016-08-31 23:06:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 23:08:51 UTC) #4
waffles
On 2016/08/31 23:08:51, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) d'oh. ...
4 years, 3 months ago (2016-08-31 23:11:48 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:12:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3dbbe45a1f8e74a80e520c2e74a8e47b84d0d72
Cr-Commit-Position: refs/heads/master@{#415794}

Powered by Google App Engine
This is Rietveld 408576698