VM: Compute static guarded cid for final instance fields.

VM: Compute static guarded cid for final instance fields.

Before the tree-shaking pass, iterate over final field initializers
and try to compute the static type.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9e1c3dd057048e8d7ce401f411bd21b35fbeb43

[Florian Schneider, 2016-09-06 19:29:50]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-09-06 20:38:41]

lgtm

https://codereview.chromium.org/2300873002/diff/40001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2300873002/diff/40001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:403: if (function.HasCode()) return;
This should only happen for const constructors right?  Maybe the code should be
cleared here and the constructor recompiled so if in

class A {
  final b = const B()
}

class B {
  final x = 'string';
  const B()
}

if we visit A before B and compile B's constructor as a side effect, we still
discover that B.x is OneByteString.

[Florian Schneider, 2016-09-06 21:00:32]

https://codereview.chromium.org/2300873002/diff/40001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2300873002/diff/40001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:403: if (function.HasCode()) return;
On 2016/09/06 20:38:41, rmacnak wrote:
> This should only happen for const constructors right?  Maybe the code should
be
> cleared here and the constructor recompiled so if in
> 
> class A {
>   final b = const B()
> }
> 
> class B {
>   final x = 'string';
>   const B()
> }
> 
> if we visit A before B and compile B's constructor as a side effect, we still
> discover that B.x is OneByteString.

Done. Yes, it happens for const-constructors.

[Florian Schneider, 2016-09-06 21:59:57]

Description was changed from

==========
VM: Compute static guarded cid for final instance fields.

Before the tree-shaking pass, iterate over final field initializers
and try to compute the static type.
==========

to

==========
VM: Compute static guarded cid for final instance fields.

Before the tree-shaking pass, iterate over final field initializers
and try to compute the static type.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c9e1c3dd057048e8d7ce401f411bd21b35fbeb43
==========

[Florian Schneider, 2016-09-06 21:59:58]

Committed patchset #4 (id:60001) manually as
c9e1c3dd057048e8d7ce401f411bd21b35fbeb43 (presubmit successful).