Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2905)

Unified Diff: chrome/browser/resources/settings/internet_page/network_proxy.js

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)
Patch Set: Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_proxy.js
diff --git a/chrome/browser/resources/settings/internet_page/network_proxy.js b/chrome/browser/resources/settings/internet_page/network_proxy.js
index 9f2ef04899b8224ad9648029733a935bf80b95b7..cc22995f52c3f20dfb348eaa2ce54f7be55d6089 100644
--- a/chrome/browser/resources/settings/internet_page/network_proxy.js
+++ b/chrome/browser/resources/settings/internet_page/network_proxy.js
@@ -22,9 +22,7 @@ Polymer({
observer: 'networkPropertiesChanged_',
},
- /**
- * Whether or not the proxy values can be edited.
- */
+ /** Whether or not the proxy values can be edited. */
editable: {
type: Boolean,
value: false,
@@ -41,18 +39,17 @@ Polymer({
},
},
- /**
- * The Web Proxy Auto Discovery URL extracted from networkProperties.
- */
+ /** The Web Proxy Auto Discovery URL extracted from networkProperties. */
WPAD: {
type: String,
value: '',
},
/**
- * Whetner or not to use the same manual proxy for all protocols.
+ * Whether or not to use the same manual proxy for all protocols.
+ * @private
*/
- useSameProxy: {
+ useSameProxy_: {
type: Boolean,
value: false,
observer: 'useSameProxyChanged_',
@@ -60,7 +57,7 @@ Polymer({
/**
* Array of proxy configuration types.
- * @type {!Array<string>}
+ * @private {!Array<string>}
* @const
*/
proxyTypes_: {
@@ -76,10 +73,10 @@ Polymer({
/**
* Object providing proxy type values for data binding.
- * @type {!Object}
+ * @private {!Object}
* @const
*/
- ProxySettingsType: {
+ ProxySettingsType_: {
type: Object,
value: {
DIRECT: CrOnc.ProxySettingsType.DIRECT,
@@ -94,14 +91,14 @@ Polymer({
/**
* Saved Manual properties so that switching to another type does not loose
* any set properties while the UI is open.
- * @type {!CrOnc.ManualProxySettings|undefined}
+ * @private {!CrOnc.ManualProxySettings|undefined}
*/
savedManual_: undefined,
/**
* Saved ExcludeDomains properties so that switching to a non-Manual type does
* not loose any set exclusions while the UI is open.
- * @type {!Array<string>|undefined}
+ * @private {!Array<string>|undefined}
*/
savedExcludeDomains_: undefined,
@@ -184,15 +181,15 @@ Polymer({
var defaultProxy = proxy.Manual.HTTPProxy;
if (!defaultProxy || !defaultProxy.Host)
return;
- if (this.useSameProxy || !proxy.Manual.SecureHTTPProxy) {
+ if (this.useSameProxy_ || !proxy.Manual.SecureHTTPProxy) {
proxy.Manual.SecureHTTPProxy = /** @type {!CrOnc.ProxyLocation} */ (
Object.assign({}, defaultProxy));
}
- if (this.useSameProxy || !proxy.Manual.FTPProxy) {
+ if (this.useSameProxy_ || !proxy.Manual.FTPProxy) {
proxy.Manual.FTPProxy = /** @type {!CrOnc.ProxyLocation} */ (
Object.assign({}, defaultProxy));
}
- if (this.useSameProxy || !proxy.Manual.SOCKS) {
+ if (this.useSameProxy_ || !proxy.Manual.SOCKS) {
proxy.Manual.SOCKS = /** @type {!CrOnc.ProxyLocation} */ (
Object.assign({}, defaultProxy));
}

Powered by Google App Engine
This is Rietveld 408576698