chrome/browser/resources/settings/internet_page/network_property_list.html - Issue 2300783002: MD Settings: Internet: Cleanup JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_property_list.html

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)

Patch Set: Feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_nameservers.js ('k') | chrome/browser/resources/settings/internet_page/network_property_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_property_list.html

diff --git a/chrome/browser/resources/settings/internet_page/network_property_list.html b/chrome/browser/resources/settings/internet_page/network_property_list.html

index d6908b087696b7176dd83fb697b88167c0bf0c05..90bff5fcf0927480cfadd32ff39aaa009ffaf2b6 100644

--- a/chrome/browser/resources/settings/internet_page/network_property_list.html

+++ b/chrome/browser/resources/settings/internet_page/network_property_list.html

@@ -21,17 +21,17 @@

<div>[[getPropertyLabel_(item, prefix)]]</div>

<div class="layout horizontal"

- hidden$="[[isEditable_(propertyDict, editFieldTypes, item, '')]]">

- <div class="secondary">[[getPropertyValue_(propertyDict, item)]]</div>

+ hidden$="[[isEditable_(item, '', propertyDict, editFieldTypes)]]">

+ <div class="secondary">[[getPropertyValue_(item, propertyDict)]]</div>

<cr-policy-network-indicator property="[[propertyDict]]">

</cr-policy-network-indicator>

</div>

<div class="layout horizontal" hidden$="[[!isEditable_(

- propertyDict, editFieldTypes, item, 'String')]]">

+ item, 'String', propertyDict, editFieldTypes)]]">

<paper-input-container no-label-float>

<input class="embedded-input" id="[[item]]" is="iron-input"

- value="[[getPropertyValue_(propertyDict, item)]]"

+ value="[[getPropertyValue_(item, propertyDict)]]"

on-blur="onValueChange_">

</paper-input-container>

</div>