Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)
Patch Set: Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
index 6bfa7e6fd02dad0aceaaa331c36f0c7bc543dc86..3926f994373ef02724a675c9ecced8110d5c24cb 100644
--- a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_known_networks_page.js
@@ -29,23 +29,21 @@ Polymer({
},
/**
+ * Interface for networkingPrivate calls, passed from internet_page.
+ * @type {NetworkingPrivate}
+ */
+ networkingPrivate: Object,
+
+ /**
* List of all network state data for the network type.
- * @type {!Array<!CrOnc.NetworkStateProperties>}
+ * @private {!Array<!CrOnc.NetworkStateProperties>}
*/
- networkStateList: {
+ networkStateList_: {
type: Array,
value: function() {
return [];
}
},
-
- /**
- * Interface for networkingPrivate calls, passed from internet_page.
- * @type {NetworkingPrivate}
- */
- networkingPrivate: {
- type: Object,
- },
},
/**
@@ -96,7 +94,7 @@ Polymer({
configured: true
};
this.networkingPrivate.getNetworks(filter, function(states) {
- this.networkStateList = states;
+ this.networkStateList_ = states;
}.bind(this));
},
@@ -124,7 +122,7 @@ Polymer({
* @private
*/
havePreferred_: function() {
- return this.networkStateList.find(function(state) {
+ return this.networkStateList_.find(function(state) {
return this.networkIsPreferred_(state);
}.bind(this)) !== undefined;
},
@@ -134,7 +132,7 @@ Polymer({
* @private
*/
haveNotPreferred_: function() {
- return this.networkStateList.find(function(state) {
+ return this.networkStateList_.find(function(state) {
return this.networkIsNotPreferred_(state);
}.bind(this)) !== undefined;
},

Powered by Google App Engine
This is Rietveld 408576698