Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4138)

Unified Diff: chrome/browser/resources/settings/internet_page/network_proxy.html

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_proxy.html
diff --git a/chrome/browser/resources/settings/internet_page/network_proxy.html b/chrome/browser/resources/settings/internet_page/network_proxy.html
index 8ed3dcbe29329c74a9d0e003b875483e5ae58c2b..a6f47043716b4d299c472e84d6d40281a0aacc30 100644
--- a/chrome/browser/resources/settings/internet_page/network_proxy.html
+++ b/chrome/browser/resources/settings/internet_page/network_proxy.html
@@ -83,10 +83,10 @@
<!-- Manual -->
<div id="proxyDiv" class="settings-box continuation single-column indented"
hidden$="[[!matches_(proxy.Type, ProxySettingsType.MANUAL)]]">
- <paper-checkbox checked="{{useSameProxy}}">
+ <paper-checkbox checked="{{useSameProxy_}}">
$i18n{networkProxyUseSame}
</paper-checkbox>
- <div hidden$="[[!useSameProxy]]" class="layout vertical">
+ <div hidden$="[[!useSameProxy_]]" class="layout vertical">
<network-proxy-input
on-proxy-change="onProxyInputChange_"
editable="[[isPropertyEditable_(editable, networkProperties,
@@ -95,7 +95,7 @@
label="$i18n{networkProxy}">
</network-proxy-input>
</div>
- <div hidden$="[[useSameProxy]]" class="layout vertical">
+ <div hidden$="[[useSameProxy_]]" class="layout vertical">
Dan Beam 2016/08/31 21:59:47 these should probably both be dom-if, no?
stevenjb 2016/08/31 22:10:17 Maybe? Not sure how aggressive we want to be about
<network-proxy-input
on-proxy-change="onProxyInputChange_"
editable="[[isPropertyEditable_(editable, networkProperties,

Powered by Google App Engine
This is Rietveld 408576698