Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/browser/resources/settings/internet_page/network_nameservers.js

Issue 2300783002: MD Settings: Internet: Cleanup JS (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_nameservers.js
diff --git a/chrome/browser/resources/settings/internet_page/network_nameservers.js b/chrome/browser/resources/settings/internet_page/network_nameservers.js
index 6a9b86fae1309d7b1805d144cd893ca26db007b3..f778cff6bc00d9b98ace62e7da5b96fb347aa5d7 100644
--- a/chrome/browser/resources/settings/internet_page/network_nameservers.js
+++ b/chrome/browser/resources/settings/internet_page/network_nameservers.js
@@ -19,9 +19,7 @@ Polymer({
observer: 'networkPropertiesChanged_',
},
- /**
- * Whether or not the nameservers can be edited.
- */
+ /** Whether or not the nameservers can be edited. */
editable: {
type: Boolean,
value: false,
@@ -31,17 +29,15 @@ Polymer({
* Array of nameserver addresses stored as strings.
* @type {!Array<string>}
*/
- nameservers: {
+ nameservers_: {
type: Array,
value: function() {
return [];
},
},
- /**
- * The selected nameserver type.
- */
- nameserversType: {
+ /** The selected nameserver type. */
+ nameserversType_: {
type: String,
value: 'automatic',
},
@@ -108,37 +104,35 @@ Polymer({
* @private
*/
setNameservers_: function(nameserversType, nameservers) {
- this.nameserversType = nameserversType;
+ this.nameserversType_ = nameserversType;
if (nameserversType == 'custom') {
// Add empty entries for unset custom nameservers.
for (let i = nameservers.length; i < this.MAX_NAMESERVERS; ++i)
nameservers[i] = '';
}
- this.nameservers = nameservers;
+ this.nameservers_ = nameservers;
},
/**
- * @param {string} nameserversType The nameservers type.
- * @return {string} The description for |nameserversType|.
+ * @param {string} type The nameservers type.
+ * @return {string} The description for |type|.
* @private
*/
- nameserverTypeDesc_: function(nameserversType) {
+ nameserverTypeDesc_: function(type) {
// TODO(stevenjb): Translate.
- if (nameserversType == 'custom')
+ if (type == 'custom')
return 'Custom name servers';
- if (nameserversType == 'google')
+ if (type == 'google')
return 'Google name servers';
return 'Automatic name servers';
},
/**
- * @param {boolean} editable The editable state.
- * @param {string} nameserversType The nameservers type.
* @return {boolean} True if the nameservers are editable.
* @private
*/
- canEdit_: function(editable, nameserversType) {
- return editable && nameserversType == 'custom';
+ canEdit_: function() {
+ return this.editable && this.nameserversType_ == 'custom';
},
/**
@@ -148,10 +142,10 @@ Polymer({
* @private
*/
onTypeChange_: function(e) {
- if (this.nameserversType == 'custom')
- this.savedNameservers_ = this.nameservers;
+ if (this.nameserversType_ == 'custom')
+ this.savedNameservers_ = this.nameservers_;
var type = e.detail.selected;
- this.nameserversType = type;
+ this.nameserversType_ = type;
if (type == 'custom') {
// Restore the saved nameservers.
this.setNameservers_(type, this.savedNameservers_);
@@ -167,7 +161,7 @@ Polymer({
* @private
*/
onValueChange_: function() {
- if (this.nameserversType != 'custom') {
+ if (this.nameserversType_ != 'custom') {
// If a user inputs Google nameservers in the custom nameservers fields,
// |nameserversType| will change to 'google' so don't send the values.
return;
@@ -180,7 +174,7 @@ Polymer({
* @private
*/
sendNameServers_: function() {
- var type = this.nameserversType;
+ var type = this.nameserversType_;
if (type == 'custom') {
let nameservers = [];

Powered by Google App Engine
This is Rietveld 408576698