MD Settings: Internet: Cleanup JS

chrome/browser/resources/settings/internet_page/network_nameservers.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying network nameserver options.
  */
 Polymer({
   is: 'network-nameservers',
 
   properties: {
     /**
      * The network properties dictionary containing the nameserver properties to
      * display and modify.
      * @type {!CrOnc.NetworkProperties|undefined}
      */
     networkProperties: {
       type: Object,
       observer: 'networkPropertiesChanged_',
     },
 
-    /**
-     * Whether or not the nameservers can be edited.
-     */
+    /** Whether or not the nameservers can be edited. */
     editable: {
       type: Boolean,
       value: false,
     },
 
     /**
      * Array of nameserver addresses stored as strings.
-     * @type {!Array<string>}
+     * @private {!Array<string>}
      */
-    nameservers: {
+    nameservers_: {
       type: Array,
       value: function() {
         return [];
       },
     },
 
     /**
      * The selected nameserver type.
+     * @private
      */
-    nameserversType: {
+    nameserversType_: {
       type: String,
       value: 'automatic',
     },
 
     /**
      * Array of nameserver types.
+     * @private
      */
     nameserverTypeNames_: {
       type: Array,
       value: ['automatic', 'google', 'custom'],
       readOnly: true,
     },
   },
 
   /** @const */
   GOOGLE_NAMESERVERS: [
     '8.8.4.4',
     '8.8.8.8',
   ],
 
   /** @const */
   MAX_NAMESERVERS: 4,
 
   /**
    * Saved nameservers when switching to 'automatic'.
-   * @type {!Array<string>}
+   * @private {!Array<string>}
    */
   savedNameservers_: [],
 
   /** @private */
   networkPropertiesChanged_: function(newValue, oldValue) {
     if (!this.networkProperties)
       return;
 
     if (!oldValue || newValue.GUID != oldValue.GUID)
       this.savedNameservers_ = [];
@@ skipping 20 matching lines @@
     }
     this.setNameservers_(type, nameservers);
   },
 
   /**
    * @param {string} nameserversType
    * @param {!Array<string>} nameservers
    * @private
    */
   setNameservers_: function(nameserversType, nameservers) {
-    this.nameserversType = nameserversType;
+    this.nameserversType_ = nameserversType;
     if (nameserversType == 'custom') {
       // Add empty entries for unset custom nameservers.
       for (let i = nameservers.length; i < this.MAX_NAMESERVERS; ++i)
         nameservers[i] = '';
     }
-    this.nameservers = nameservers;
+    this.nameservers_ = nameservers;
   },
 
   /**
-   * @param {string} nameserversType The nameservers type.
-   * @return {string} The description for |nameserversType|.
+   * @param {string} type The nameservers type.
+   * @return {string} The description for |type|.
    * @private
    */
-  nameserverTypeDesc_: function(nameserversType) {
+  nameserverTypeDesc_: function(type) {
     // TODO(stevenjb): Translate.
-    if (nameserversType == 'custom')
+    if (type == 'custom')
       return 'Custom name servers';
-    if (nameserversType == 'google')
+    if (type == 'google')
       return 'Google name servers';
     return 'Automatic name servers';
   },
 
   /**
-   * @param {boolean} editable The editable state.
-   * @param {string} nameserversType The nameservers type.
    * @return {boolean} True if the nameservers are editable.
    * @private
    */
-  canEdit_: function(editable, nameserversType) {
-    return editable && nameserversType == 'custom';
+  canEdit_: function() {
+    return this.editable && this.nameserversType_ == 'custom';
   },
 
   /**
    * Event triggered when the selected type changes. Updates nameservers and
    * sends the change value if necessary.
    * @param {!{detail: !{selected: string}}} e
    * @private
    */
   onTypeChange_: function(e) {
-    if (this.nameserversType == 'custom')
-      this.savedNameservers_ = this.nameservers;
+    if (this.nameserversType_ == 'custom')
+      this.savedNameservers_ = this.nameservers_;
     var type = e.detail.selected;
-    this.nameserversType = type;
+    this.nameserversType_ = type;
     if (type == 'custom') {
       // Restore the saved nameservers.
       this.setNameservers_(type, this.savedNameservers_);
       // Only send custom nameservers if they are not empty.
       if (this.savedNameservers_.length == 0)
         return;
     }
     this.sendNameServers_();
   },
 
   /**
    * Event triggered when a nameserver value changes.
    * @private
    */
   onValueChange_: function() {
-    if (this.nameserversType != 'custom') {
+    if (this.nameserversType_ != 'custom') {
       // If a user inputs Google nameservers in the custom nameservers fields,
       // |nameserversType| will change to 'google' so don't send the values.
       return;
     }
     this.sendNameServers_();
   },
 
   /**
    * Sends the current nameservers type (for automatic) or value.
    * @private
    */
   sendNameServers_: function() {
-    var type = this.nameserversType;
+    var type = this.nameserversType_;
 
     if (type == 'custom') {
       let nameservers = [];
       for (let i = 0; i < this.MAX_NAMESERVERS; ++i) {
         let id = 'nameserver' + i;
         let nameserverInput = this.$$('#' + id);
         let nameserver = '';
         if (nameserverInput)
           nameserver = this.$$('#' + id).value;
         nameservers.push(nameserver);
@@ skipping 10 matching lines @@
       });
     } else {
       // automatic
       this.fire('nameservers-change', {
         field: 'NameServersConfigType',
         value: CrOnc.IPConfigType.DHCP,
       });
     }
   },
 });