Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: test/cctest/wasm/test-run-wasm-simd.cc

Issue 2300753005: [wasm] fix Simd ExtractLane to take immediate instead of param (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: [wasm] fix Simd ExtractLane to take immediate instead of param Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-opcodes.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-simd.cc
diff --git a/test/cctest/wasm/test-run-wasm-simd.cc b/test/cctest/wasm/test-run-wasm-simd.cc
index 4c79cb5222f8e9121608528d88094484649b6245..76eac5e793e77c43a1f1041619813576828f4868 100644
--- a/test/cctest/wasm/test-run-wasm-simd.cc
+++ b/test/cctest/wasm/test-run-wasm-simd.cc
@@ -29,24 +29,21 @@ WASM_EXEC_TEST(Splat) {
WasmRunner<int32_t> r(kExecuteCompiled, MachineType::Int32());
r.AllocateLocal(kAstS128);
BUILD(r,
- WASM_BLOCK(WASM_SET_LOCAL(1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(0))),
- WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0),
- WASM_SIMD_I32x4_EXTRACT_LANE(
- WASM_GET_LOCAL(1), WASM_I8(0))),
- WASM_RETURN1(WASM_ZERO)),
- WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0),
- WASM_SIMD_I32x4_EXTRACT_LANE(
- WASM_GET_LOCAL(1), WASM_I8(1))),
- WASM_RETURN1(WASM_ZERO)),
- WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0),
- WASM_SIMD_I32x4_EXTRACT_LANE(
- WASM_GET_LOCAL(1), WASM_I8(2))),
- WASM_RETURN1(WASM_ZERO)),
- WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0),
- WASM_SIMD_I32x4_EXTRACT_LANE(
- WASM_GET_LOCAL(1), WASM_I8(3))),
- WASM_RETURN1(WASM_ZERO)),
- WASM_RETURN1(WASM_ONE)));
+ WASM_BLOCK(
+ WASM_SET_LOCAL(1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(0))),
+ WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 0, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 1, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 2, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_IF(WASM_I32_NE(WASM_GET_LOCAL(0), WASM_SIMD_I32x4_EXTRACT_LANE(
+ 3, WASM_GET_LOCAL(1))),
+ WASM_RETURN1(WASM_ZERO)),
+ WASM_RETURN1(WASM_ONE)));
FOR_INT32_INPUTS(i) { CHECK_EQ(1, r.Call(*i)); }
}
« no previous file with comments | « src/wasm/wasm-opcodes.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698