src/wasm/wasm-macro-gen.h - Issue 2300753005: [wasm] fix Simd ExtractLane to take immediate instead of param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-macro-gen.h

Issue 2300753005: [wasm] fix Simd ExtractLane to take immediate instead of param (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: [wasm] fix Simd ExtractLane to take immediate instead of param Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/wasm-macro-gen.h

diff --git a/src/wasm/wasm-macro-gen.h b/src/wasm/wasm-macro-gen.h

index 9a87f0ff95f5844c90bbec6a85aab7b8d242bb1a..9f46041c36f26c7c255ee460c95cd59fd70e72fb 100644

--- a/src/wasm/wasm-macro-gen.h

+++ b/src/wasm/wasm-macro-gen.h

@@ -589,8 +589,8 @@ class LocalDeclEncoder {

// Simd Operations.

//------------------------------------------------------------------------------

#define WASM_SIMD_I32x4_SPLAT(x) x, kSimdPrefix, kExprI32x4Splat & 0xff

-#define WASM_SIMD_I32x4_EXTRACT_LANE(x, y) \

- x, y, kSimdPrefix, kExprI32x4ExtractLane & 0xff

+#define WASM_SIMD_I32x4_EXTRACT_LANE(lane, x) \

+ x, kSimdPrefix, kExprI32x4ExtractLane & 0xff, static_cast<byte>(lane)

#define SIG_ENTRY_v_v kWasmFunctionTypeForm, 0, 0

#define SIZEOF_SIG_ENTRY_v_v 3

« no previous file with comments | « src/wasm/ast-decoder.cc ('k') | src/wasm/wasm-opcodes.h » ('j') | no next file with comments »