Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: src/wasm/wasm-macro-gen.h

Issue 2300753005: [wasm] fix Simd ExtractLane to take immediate instead of param (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: [wasm] fix Simd ExtractLane to take immediate instead of param Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-macro-gen.h
diff --git a/src/wasm/wasm-macro-gen.h b/src/wasm/wasm-macro-gen.h
index 9a87f0ff95f5844c90bbec6a85aab7b8d242bb1a..da431c701e9a1e7f90b9576d96196ad4adde7389 100644
--- a/src/wasm/wasm-macro-gen.h
+++ b/src/wasm/wasm-macro-gen.h
@@ -590,7 +590,7 @@ class LocalDeclEncoder {
//------------------------------------------------------------------------------
#define WASM_SIMD_I32x4_SPLAT(x) x, kSimdPrefix, kExprI32x4Splat & 0xff
#define WASM_SIMD_I32x4_EXTRACT_LANE(x, y) \
titzer 2016/09/01 08:32:43 If y is the immediate, then generally it should co
aseemgarg 2016/09/02 22:40:13 Done.
- x, y, kSimdPrefix, kExprI32x4ExtractLane & 0xff
+ x, kSimdPrefix, kExprI32x4ExtractLane & 0xff, static_cast<byte>(y)
#define SIG_ENTRY_v_v kWasmFunctionTypeForm, 0, 0
#define SIZEOF_SIG_ENTRY_v_v 3

Powered by Google App Engine
This is Rietveld 408576698