Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: src/wasm/wasm-opcodes.h

Issue 2300753005: [wasm] fix Simd ExtractLane to take immediate instead of param (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-opcodes.h
diff --git a/src/wasm/wasm-opcodes.h b/src/wasm/wasm-opcodes.h
index 1412587097e5bc0790d47c4d23c77fd35ce9be21..706b0b97e8f27d63a222626a174a7b03a071e223 100644
--- a/src/wasm/wasm-opcodes.h
+++ b/src/wasm/wasm-opcodes.h
@@ -275,7 +275,6 @@ const WasmCodePosition kNoCodePosition = -1;
#define FOREACH_SIMD_OPCODE(V) \
V(F32x4Splat, 0xe500, s_f) \
- V(F32x4ExtractLane, 0xe501, f_si) \
V(F32x4ReplaceLane, 0xe502, s_sif) \
V(F32x4Abs, 0xe503, s_s) \
V(F32x4Neg, 0xe504, s_s) \
@@ -302,7 +301,6 @@ const WasmCodePosition kNoCodePosition = -1;
V(F32x4FromInt32x4, 0xe519, s_s) \
V(F32x4FromUint32x4, 0xe51a, s_s) \
V(I32x4Splat, 0xe51b, s_i) \
- V(I32x4ExtractLane, 0xe51c, i_si) \
V(I32x4ReplaceLane, 0xe51d, s_sii) \
V(I32x4Neg, 0xe51e, s_s) \
V(I32x4Add, 0xe51f, s_ss) \
@@ -331,7 +329,6 @@ const WasmCodePosition kNoCodePosition = -1;
V(I32x4Ge_u, 0xe536, s_ss) \
V(Ui32x4FromFloat32x4, 0xe537, s_s) \
V(I16x8Splat, 0xe538, s_i) \
- V(I16x8ExtractLane, 0xe539, i_si) \
V(I16x8ReplaceLane, 0xe53a, s_sii) \
V(I16x8Neg, 0xe53b, s_s) \
V(I16x8Add, 0xe53c, s_ss) \
@@ -362,7 +359,6 @@ const WasmCodePosition kNoCodePosition = -1;
V(I16x8Gt_u, 0xe555, s_ss) \
V(I16x8Ge_u, 0xe556, s_ss) \
V(I8x16Splat, 0xe557, s_i) \
- V(I8x16ExtractLane, 0xe558, i_si) \
V(I8x16ReplaceLane, 0xe559, s_sii) \
V(I8x16Neg, 0xe55a, s_s) \
V(I8x16Add, 0xe55b, s_ss) \
@@ -397,6 +393,12 @@ const WasmCodePosition kNoCodePosition = -1;
V(S128Xor, 0xe578, s_ss) \
V(S128Not, 0xe579, s_s)
+#define FOREACH_SIMD_MISC_OPCODE(V) \
+ V(F32x4ExtractLane, 0xe501, _) \
+ V(I32x4ExtractLane, 0xe51c, _) \
+ V(I16x8ExtractLane, 0xe539, _) \
+ V(I8x16ExtractLane, 0xe558, _)
+
// All opcodes.
#define FOREACH_OPCODE(V) \
FOREACH_CONTROL_OPCODE(V) \
@@ -407,7 +409,8 @@ const WasmCodePosition kNoCodePosition = -1;
FOREACH_LOAD_MEM_OPCODE(V) \
FOREACH_MISC_MEM_OPCODE(V) \
FOREACH_ASMJS_COMPAT_OPCODE(V) \
- FOREACH_SIMD_OPCODE(V)
+ FOREACH_SIMD_OPCODE(V) \
+ FOREACH_SIMD_MISC_OPCODE(V)
// All signatures.
#define FOREACH_SIGNATURE(V) \
@@ -443,12 +446,10 @@ const WasmCodePosition kNoCodePosition = -1;
#define FOREACH_SIMD_SIGNATURE(V) \
V(s_s, kAstS128, kAstS128) \
V(s_f, kAstS128, kAstF32) \
- V(f_si, kAstF32, kAstS128, kAstI32) \
V(s_sif, kAstS128, kAstS128, kAstI32, kAstF32) \
V(s_ss, kAstS128, kAstS128, kAstS128) \
V(s_sss, kAstS128, kAstS128, kAstS128, kAstS128) \
V(s_i, kAstS128, kAstI32) \
- V(i_si, kAstI32, kAstS128, kAstI32) \
V(s_sii, kAstS128, kAstS128, kAstI32, kAstI32) \
V(s_si, kAstS128, kAstS128, kAstI32)

Powered by Google App Engine
This is Rietveld 408576698