[wasm] fix Simd ExtractLane to take immediate instead of param

src/compiler/wasm-compiler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/wasm-compiler.h"
 
 #include <memory>
 
 #include "src/isolate-inl.h"
 
@@ skipping 2872 matching lines @@
   // TODO(gdeepti): Introduce Simd128Constant to common-operator.h and use
   // instead of creating a SIMD Value.
   return graph()->NewNode(jsgraph()->machine()->CreateInt32x4(),
                           Int32Constant(0), Int32Constant(0), Int32Constant(0),
                           Int32Constant(0));
 }
 
 Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
                                const NodeVector& inputs) {
   switch (opcode) {
-    case wasm::kExprI32x4ExtractLane:
-      return graph()->NewNode(jsgraph()->machine()->Int32x4ExtractLane(),
-                              inputs[0], inputs[1]);
     case wasm::kExprI32x4Splat:
       return graph()->NewNode(jsgraph()->machine()->CreateInt32x4(), inputs[0],
                               inputs[0], inputs[0], inputs[0]);
     default:
       return graph()->NewNode(UnsupportedOpcode(opcode), nullptr);
   }
 }
 
+Node* WasmGraphBuilder::SimdExtractLane(wasm::WasmOpcode opcode, uint8_t lane,
+                                        Node* input) {
+  switch (opcode) {
+    case wasm::kExprI32x4ExtractLane:
+      return graph()->NewNode(jsgraph()->machine()->Int32x4ExtractLane(), input,
+                              Int32Constant(lane));
+    default:
+      return graph()->NewNode(UnsupportedOpcode(opcode), nullptr);
+  }
+}
+

[gdeepti, 2016/09/01 00:52:52]

This can be merged into the function above by taking an optional lane argument,
IMO it's nicer to have one source of truth that can handle the different ops. 

[aseemgarg, 2016/09/02 22:40:12]

I'm not keen on having a single function as there are a huge number of opcodes.
I was thinking grouping into few functions that would keep the function sizes
small and also allow for sharing code between cases. Or at least 2 functions for
the types with an immediate and without.

 static void RecordFunctionCompilation(CodeEventListener::LogEventsAndTags tag,
                                       Isolate* isolate, Handle<Code> code,
                                       const char* message, uint32_t index,
                                       const wasm::WasmName& module_name,
                                       const wasm::WasmName& func_name) {
   DCHECK(isolate->logger()->is_logging_code_events() ||
          isolate->is_profiling());
 
   ScopedVector<char> buffer(128);
   SNPrintF(buffer, "%s#%d:%.*s:%.*s", message, index, module_name.length(),
@@ skipping 335 matching lines @@
                             function_->code_start_offset),
            compile_ms);
   }
 
   return code;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8