Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2300753004: MD Settings menu should be visible (Closed)
Patch Set: closure Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.html ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index 61f75181fc068982fd9970aea9b49a26e6431cbe..910bddc3e576e85a8ebbdffc636dd243ff2c66d0 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -36,9 +36,6 @@ Polymer({
* @private {!GuestModePageVisibility}
*/
pageVisibility_: Object,
-
- /** @private */
- drawerOpened_: Boolean,
},
/**
@@ -51,8 +48,14 @@ Polymer({
this.$$('settings-main').searchContents(e.detail);
}.bind(this));
+ // Lazy-create the drawer the first time it is opened or swiped into view.
+ var drawer = assert(this.$$('app-drawer'));
+ listenOnce(drawer, 'track opened-changed', function() {
+ this.$.drawerTemplate.if = true;
+ }.bind(this));
+
window.addEventListener('popstate', function(e) {
- this.$$('app-drawer').close();
+ drawer.close();
}.bind(this));
if (loadTimeData.getBoolean('isGuest')) {
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.html ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698