Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2300753003: [TTS] Cleanup a potential issue introduced in CL 2157793002 (Closed)

Created:
4 years, 3 months ago by Donn Denman
Modified:
4 years, 2 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Cleanup a potential issue introduced in CL 2157793002 Refactoring done in that CL looks like it could introduce potential problems because now there's a path through the affected method that does not reset the context. This CL refactors the affected method to always reset the context while preserving the refactoring done in 2157793002. BUG=626770 Committed: https://crrev.com/e4fcb595ed939ec2f912d6fdd211ce70c73ee0ce Cr-Commit-Position: refs/heads/master@{#421279}

Patch Set 1 #

Patch Set 2 : Just a rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_delegate.cc View 1 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Donn Denman
Theresa, PTAL when convenient.
4 years, 2 months ago (2016-09-26 23:42:58 UTC) #3
Theresa
lgtm
4 years, 2 months ago (2016-09-27 18:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300753003/20001
4 years, 2 months ago (2016-09-27 18:04:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 18:40:04 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:48:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4fcb595ed939ec2f912d6fdd211ce70c73ee0ce
Cr-Commit-Position: refs/heads/master@{#421279}

Powered by Google App Engine
This is Rietveld 408576698