Enable leveldb build in GN world.

Enable leveldb build in GN world.

$ gn gn out/Debug_gn
$ ninja -C out/Debug_gn leveldatabase

BUG=None
TEST=see above, it LINKS.
R=dpranke@chromium.org
TBR=brettw

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263506

[tfarina, 2014-04-09 03:58:35]

Is this OK?

If it is, you may check the CQ box.

Thanks,

[Dirk Pranke, 2014-04-09 04:25:55]

lgtm.

The CQ has a one-in-four chance of catching a problem if there is one, but you
should be able to just run the try job directly first (select
'linux_chromium_gn_rel' from the 'try more bots' list), so can you try that, and
assuming that works, either commit it yourself or let brett or I know to do so?

[tfarina, 2014-04-09 23:33:53]

Hopefully I ran this through the trybots. I was building just leveldatabase, not
everything.

Well, it discovered that there are some issues with leveldatabase (not sure how
this passed before) and with snappy.

So I can't land this yet. I will have to fix those compilation issues first.

[tfarina, 2014-04-12 02:30:39]

Dirk, this is passing for me locally now.

I have built env_chromium_unittests target with a fix which I included in patch
set two.

I'm doing a full release build now with the following command line:

$ gn gen out/Release_gn --args="is_debug=false is_clang=true"
$ ninja -C out/Release_gn

If everything goes well, I will put this in CQ.

[Dirk Pranke, 2014-04-12 02:38:02]

sounds good :).

[tfarina, 2014-04-12 02:42:06]

On 2014/04/12 02:38:02, Dirk Pranke wrote:
> sounds good :).

Dirk, are GN bots GCC only?

I hit this https://codereview.chromium.org/234833005/diff/1/BUILD.gn#newcode81
when building with clang.

Trying a gcc build right now.

[Dirk Pranke, 2014-04-12 02:44:28]

On 2014/04/12 02:42:06, tfarina wrote:
> On 2014/04/12 02:38:02, Dirk Pranke wrote:
> > sounds good :).
> 
> Dirk, are GN bots GCC only?
> 

I believe we only have GCC coverage on Linux so far, yes.

[tfarina, 2014-04-12 02:50:55]

On 2014/04/12 02:44:28, Dirk Pranke wrote:
> On 2014/04/12 02:42:06, tfarina wrote:
> > Dirk, are GN bots GCC only?
> > 
> 
> I believe we only have GCC coverage on Linux so far, yes.

That is "good", at least for now, since everything linked when building with
gcc:

$ ninja -C out/Release_gn 
ninja: Entering directory `out/Release_gn'
[2247/2247] LINK gfx_unittests

Pushing to cq.

[tfarina, 2014-04-12 03:01:42]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-04-12 03:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/230073003/40001

[commit-bot: I haz the power, 2014-04-12 10:37:35]

Change committed as 263506