Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/resources/file_manager/foreground/js/file_manager.js

Issue 230073002: Files.app: Reland r261616: Add a test to rename a file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/foreground/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/foreground/js/file_manager.js b/chrome/browser/resources/file_manager/foreground/js/file_manager.js
index 7416f7e567f3a85684aa3487cdff2d25624ddc49..6338a156b7b9bd405e6f3cb944f3ebdb4d2ac8d2 100644
--- a/chrome/browser/resources/file_manager/foreground/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/foreground/js/file_manager.js
@@ -2480,8 +2480,8 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
return;
}
- var nameNode = this.findListItemForNode_(this.renameInput_).
- querySelector('.filename-label');
+ var renamedItemElement = this.findListItemForNode_(this.renameInput_);
+ var nameNode = renamedItemElement.querySelector('.filename-label');
input.validation_ = true;
var validationDone = function(valid) {
@@ -2498,15 +2498,19 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52;
// Optimistically apply new name immediately to avoid flickering in
// case of success.
nameNode.textContent = newName;
+ // Add a marker of the provisional change for test cases.
+ renamedItemElement.classList.add('provisional');
util.rename(
entry, newName,
function(newEntry) {
this.directoryModel_.onRenameEntry(entry, newEntry);
+ renamedItemElement.classList.remove('provisional');
}.bind(this),
function(error) {
// Write back to the old name.
nameNode.textContent = entry.name;
+ renamedItemElement.classList.remove('provisional');
// Show error dialog.
var message;

Powered by Google App Engine
This is Rietveld 408576698