Files.app: Reland r261616: Add a test to rename a file.

chrome/browser/resources/file_manager/foreground/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
@@ skipping 2398 matching lines @@
   };
 
   FileManager.prototype.initiateRename = function() {
     var item = this.currentList_.ensureLeadItemExists();
     if (!item)
       return;
     var label = item.querySelector('.filename-label');
     var input = this.renameInput_;
 
     input.value = label.textContent;
-    label.parentNode.setAttribute('renaming', '');
+    item.setAttribute('renaming', '');
     label.parentNode.appendChild(input);
     input.focus();
     var selectionEnd = input.value.lastIndexOf('.');
     if (selectionEnd == -1) {
       input.select();
     } else {
       input.selectionStart = 0;
       input.selectionEnd = selectionEnd;
     }
 
     // This has to be set late in the process so we don't handle spurious
     // blur events.
     input.currentEntry = this.currentList_.dataModel.item(item.listIndex);
+    this.table_.startBatchUpdates();
+    this.grid_.startBatchUpdates();
   };
 
   /**
    * @type {Event} Key event.
    * @private
    */
   FileManager.prototype.onRenameInputKeyDown_ = function(event) {
     if (!this.isRenamingInProgress())
       return;
 
@@ skipping 30 matching lines @@
   FileManager.prototype.commitRename_ = function() {
     var input = this.renameInput_;
     var entry = input.currentEntry;
     var newName = input.value;
 
     if (newName == entry.name) {
       this.cancelRename_();
       return;
     }
 
-    var nameNode = this.findListItemForNode_(this.renameInput_).
-                   querySelector('.filename-label');
+    var renamedItemElement = this.findListItemForNode_(this.renameInput_);
+    var nameNode = renamedItemElement.querySelector('.filename-label');
 
     input.validation_ = true;
     var validationDone = function(valid) {
       input.validation_ = false;
-      // Alert dialog restores focus unless the item removed from DOM.
-      if (this.document_.activeElement != input)
-        this.cancelRename_();
-      if (!valid)
+
+      if (!valid) {
+        // Cancel rename if it fails to restore focus from alert dialog.
+        // Otherwise, just cancel the commitment and continue to rename.
+        if (this.document_.activeElement != input)
+          this.cancelRename_();
         return;
+      }
 
       // Validation succeeded. Do renaming.
+      this.renameInput_.currentEntry = null;
+      if (this.renameInput_.parentNode)
+        this.renameInput_.parentNode.removeChild(this.renameInput_);
+      renamedItemElement.setAttribute('renaming', 'provisional');
 
-      this.cancelRename_();
       // Optimistically apply new name immediately to avoid flickering in
       // case of success.
       nameNode.textContent = newName;
 
       util.rename(
           entry, newName,
           function(newEntry) {
             this.directoryModel_.onRenameEntry(entry, newEntry);
+            renamedItemElement.removeAttribute('renaming');
+            this.table_.endBatchUpdates();
+            this.grid_.endBatchUpdates();
           }.bind(this),
           function(error) {
             // Write back to the old name.
             nameNode.textContent = entry.name;
+            renamedItemElement.removeAttribute('renaming');
+            this.table_.endBatchUpdates();
+            this.grid_.endBatchUpdates();
 
             // Show error dialog.
             var message;
             if (error.name == util.FileError.PATH_EXISTS_ERR ||
                 error.name == util.FileError.TYPE_MISMATCH_ERR) {
               // Check the existing entry is file or not.
               // 1) If the entry is a file:
               //   a) If we get PATH_EXISTS_ERR, a file exists.
               //   b) If we get TYPE_MISMATCH_ERR, a directory exists.
               // 2) If the entry is a directory:
@@ skipping 23 matching lines @@
                            newName,
                            validationDone.bind(this));
   };
 
   /**
    * @private
    */
   FileManager.prototype.cancelRename_ = function() {
     this.renameInput_.currentEntry = null;
 
+    var item = this.findListItemForNode_(this.renameInput_);
+    if (item)
+      item.removeAttribute('renaming');
+
     var parent = this.renameInput_.parentNode;
-    if (parent) {
-      parent.removeAttribute('renaming');
+    if (parent)
       parent.removeChild(this.renameInput_);
-    }
+
+    this.table_.endBatchUpdates();
+    this.grid_.endBatchUpdates();
   };
 
   /**
    * @param {Event} Key event.
    * @private
    */
   FileManager.prototype.onFilenameInputInput_ = function() {
     this.selectionHandler_.updateOkButton();
   };
 
@@ skipping 1148 matching lines @@
       callback(this.preferences_);
       return;
     }
 
     chrome.fileBrowserPrivate.getPreferences(function(prefs) {
       this.preferences_ = prefs;
       callback(prefs);
     }.bind(this));
   };
 })();