Issue 2300723003: Fix data race in WebRtcAudioRenderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2300723003: Fix data race in WebRtcAudioRenderer. (Closed)

Created:
4 years, 3 months ago by Henrik Grunell

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Fix data race in WebRtcAudioRenderer. Accessing |max_render_time_| under |lock_| in Stop(). It's already accessed under the lock in the other place. BUG=641339 Review-Url: https://codereview.chromium.org/2292053002 Cr-Commit-Position: refs/heads/master@{#415617} (cherry picked from commit c0a322db0a71e6d63f4905d4b55f27d83f55726d) Committed: https://chromium.googlesource.com/chromium/src/+/7d219e2c368bbae0a376f11f72d8bc46564a6c30

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	content/renderer/media/webrtc_audio_renderer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/renderer/media/webrtc_audio_renderer.cc	View		2 chunks	+13 lines, -9 lines	0 comments	Download

Total messages: 2 (1 generated)

Henrik Grunell

4 years, 3 months ago (2016-09-01 11:51:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7d219e2c368bbae0a376f11f72d8bc46564a6c30.