infra/bots/recipe_modules/flavor/pdfium_flavor.py - Issue 2300703007: pdfium: Fix the pdfium builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/flavor/pdfium_flavor.py

Issue 2300703007: pdfium: Fix the pdfium builder. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipe_modules/flavor/pdfium_flavor.py

diff --git a/infra/bots/recipe_modules/flavor/pdfium_flavor.py b/infra/bots/recipe_modules/flavor/pdfium_flavor.py

index 12a4f808e9370737b3c9ed1c2a427cc562c840a9..3ffd28d34d53146c4b4b4eedbd3dc587cb78a89e 100644

--- a/infra/bots/recipe_modules/flavor/pdfium_flavor.py

+++ b/infra/bots/recipe_modules/flavor/pdfium_flavor.py

@@ -25,8 +25,15 @@ class PDFiumFlavorUtils(default_flavor.DefaultFlavorUtils):

**kwargs)

# Setup gn args.

- gn_args = ['pdf_use_skia=true', 'pdf_is_standalone=true',

- 'clang_use_chrome_plugins=false']

+ gn_args = [

+ 'pdf_use_skia=true',

+ 'pdf_is_standalone=true',

+ 'clang_use_chrome_plugins=false',

+ 'is_component_build=false',

+ 'is_debug=false',

+ ]

borenet 2016/09/02 18:45:19 Nit: 4-space indent.

jcgregorio 2016/09/02 19:06:39 Fixed.

env = kwargs.pop('env', {})

env['CHROMIUM_BUILDTOOLS_PATH'] = str(pdfium_dir.join('buildtools'))

self.m.run(

« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Release-PDFium.json » ('j') | no next file with comments »