Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: headless/lib/browser/headless_browser_main_parts.cc

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)
Patch Set: for_landing! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_browser_main_parts.h ('k') | headless/lib/browser/headless_devtools.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_browser_main_parts.cc
diff --git a/headless/lib/browser/headless_browser_main_parts.cc b/headless/lib/browser/headless_browser_main_parts.cc
index b2ff2f31074081f33478c30c65e642aa37e61252..0c75e132bab7e4a7a5126b4a28d4d5419b7c24da 100644
--- a/headless/lib/browser/headless_browser_main_parts.cc
+++ b/headless/lib/browser/headless_browser_main_parts.cc
@@ -4,7 +4,6 @@
#include "headless/lib/browser/headless_browser_main_parts.h"
-#include "components/devtools_http_handler/devtools_http_handler.h"
#include "headless/lib/browser/headless_browser_context_impl.h"
#include "headless/lib/browser/headless_browser_impl.h"
#include "headless/lib/browser/headless_devtools.h"
@@ -32,16 +31,13 @@ HeadlessBrowserMainParts::HeadlessBrowserMainParts(HeadlessBrowserImpl* browser)
HeadlessBrowserMainParts::~HeadlessBrowserMainParts() {}
void HeadlessBrowserMainParts::PreMainMessageLoopRun() {
- if (browser_->options()->devtools_endpoint.address().IsValid()) {
- devtools_http_handler_ =
- CreateLocalDevToolsHttpHandler(browser_->options());
- }
+ if (browser_->options()->devtools_endpoint.address().IsValid())
+ StartLocalDevToolsHttpHandler(browser_->options());
PlatformInitialize(browser_->options()->window_size);
}
void HeadlessBrowserMainParts::PostMainMessageLoopRun() {
- devtools_http_handler_.reset();
-
+ StopLocalDevToolsHttpHandler();
PlatformExit();
}
« no previous file with comments | « headless/lib/browser/headless_browser_main_parts.h ('k') | headless/lib/browser/headless_devtools.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698