Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: content/public/browser/devtools_agent_host.h

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)
Patch Set: for review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_agent_host.h
diff --git a/content/public/browser/devtools_agent_host.h b/content/public/browser/devtools_agent_host.h
index 6ec93f2c4e6c88959e409ceb32153e9d50522ec2..4a5c658d473125a218834caca0d5dfae668163b4 100644
--- a/content/public/browser/devtools_agent_host.h
+++ b/content/public/browser/devtools_agent_host.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/callback.h"
+#include "base/files/file_path.h"
#include "base/memory/ref_counted.h"
#include "base/time/time.h"
#include "content/common/content_export.h"
@@ -29,6 +30,7 @@ namespace content {
class BrowserContext;
class DevToolsExternalAgentProxyDelegate;
class DevToolsManagerDelegate;
+class DevToolsSocketFactory;
class RenderFrameHost;
class WebContents;
@@ -111,6 +113,24 @@ class CONTENT_EXPORT DevToolsAgentHost
// Returns all possible DevToolsAgentHosts embedder is aware of.
static List DiscoverAllHosts();
+ // Starts remote debugging.
+ // Takes ownership over |socket_factory|.
+ // If |frontend_url| is empty, assumes it's bundled.
+ // If |active_port_output_directory| is non-empty, it is assumed the
+ // socket_factory was initialized with an ephemeral port (0). The
+ // port selected by the OS will be written to a well-known file in
+ // the output directory.
+ static void StartRemoteDebuggingServer(
+ std::unique_ptr<DevToolsSocketFactory> server_socket_factory,
+ const std::string& frontend_url,
+ const base::FilePath& active_port_output_directory,
+ const base::FilePath& debug_frontend_dir,
+ const std::string& product_name,
+ const std::string& user_agent);
+
+ // Stops remote debugging.
+ static void StopRemoteDebuggingServer();
+
// Attaches |client| to this agent host to start debugging.
// Returns true iff attach succeeded.
virtual bool AttachClient(DevToolsAgentHostClient* client) = 0;

Powered by Google App Engine
This is Rietveld 408576698