Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4056)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.cc

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)
Patch Set: for review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/devtools_manager_delegate_android.cc
diff --git a/chrome/browser/android/devtools_manager_delegate_android.cc b/chrome/browser/android/devtools_manager_delegate_android.cc
index 051817fc56e30564ab166c0d244443533d929d22..e492e610153059e084a5748e7c257c4b09f5782f 100644
--- a/chrome/browser/android/devtools_manager_delegate_android.cc
+++ b/chrome/browser/android/devtools_manager_delegate_android.cc
@@ -13,11 +13,13 @@
#include "chrome/browser/ui/android/tab_model/tab_model.h"
#include "chrome/browser/ui/android/tab_model/tab_model_list.h"
#include "chrome/common/features.h"
+#include "chrome/grit/browser_resources.h"
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/devtools_agent_host_client.h"
#include "content/public/browser/devtools_external_agent_proxy.h"
#include "content/public/browser/devtools_external_agent_proxy_delegate.h"
#include "content/public/browser/web_contents.h"
+#include "ui/base/resource/resource_bundle.h"
using content::DevToolsAgentHost;
using content::WebContents;
@@ -250,6 +252,16 @@ DevToolsManagerDelegateAndroid::CreateNewTarget(const GURL& url) {
return DevToolsAgentHost::Create(new TabProxyDelegate(tab));
}
+std::string DevToolsManagerDelegateAndroid::GetDiscoveryPageHTML() {
+ return ResourceBundle::GetSharedInstance().GetRawDataResource(
+ IDR_DEVTOOLS_DISCOVERY_PAGE_HTML).as_string();
+}
+
+std::string DevToolsManagerDelegateAndroid::GetFrontendResource(
+ const std::string& path) {
+ return std::string();
+}
+
void DevToolsManagerDelegateAndroid::DevToolsAgentStateChanged(
DevToolsAgentHost* agent_host, bool attached) {
network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);

Powered by Google App Engine
This is Rietveld 408576698