components/precache/core/precache_fetcher.h - Issue 2300703004: Fix precache issue with cancel and resume

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/precache/core/precache_fetcher.h

Issue 2300703004: Fix precache issue with cancel and resume (Closed)

Patch Set: Addressed sclittle comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/precache/core/precache_fetcher.h

diff --git a/components/precache/core/precache_fetcher.h b/components/precache/core/precache_fetcher.h

index 927581f46c7cda005468b459921a83ec926f6233..3c6f9e6e612ebf6e7c982147b0fc36ea722d6aa4 100644

--- a/components/precache/core/precache_fetcher.h

+++ b/components/precache/core/precache_fetcher.h

@@ -152,6 +152,8 @@ class PrecacheFetcher : public base::SupportsWeakPtr<PrecacheFetcher> {

private:

friend class PrecacheFetcherTest;

FRIEND_TEST_ALL_PREFIXES(PrecacheFetcherTest, FetcherPoolMaxLimitReached);

+ FRIEND_TEST_ALL_PREFIXES(PrecacheFetcherTest,

+ CancelPrecachingAfterAllManifestFetch);

// Notifies the precache delete that precaching is done, and report

// completion statistics.