chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js - Issue 23007021: Report Javascript Runtime Errors to the Error Console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_render_view_observer.cc ('k') | chrome/test/data/extensions/error_console/browser_action_runtime_error/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js

diff --git a/chrome/test/data/extensions/api_test/file_system/open_directory_with_only_write/background.js b/chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js

similarity index 53%

copy from chrome/test/data/extensions/api_test/file_system/open_directory_with_only_write/background.js

copy to chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js

index e63978ce68a8f3b700fd0dd71651c15b7186feef..892135470961435c8d109f22cd9cee6843680d0c 100644

--- a/chrome/test/data/extensions/api_test/file_system/open_directory_with_only_write/background.js

+++ b/chrome/test/data/extensions/error_console/browser_action_runtime_error/browser_action.js

@@ -2,6 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-chrome.app.runtime.onLaunched.addListener(function () {

- chrome.app.window.create('test.html');

+chrome.browserAction.onClicked.addListener(function(tab) {

+ // This will cause a javascript error, since these are not defined.

+ foobar = baz;

});