Report Javascript Runtime Errors to the Error Console

chrome/browser/extensions/extension_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_host.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/memory/singleton.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/extensions/error_console/error_console.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/file_select_helper.h"
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h"
@@ skipping 12 matching lines @@
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
+#include "extensions/browser/extension_error.h"
 #include "extensions/browser/view_type_utils.h"
+#include "extensions/common/constants.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if !defined(OS_ANDROID)
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #endif
@@ skipping 355 matching lines @@
     switch (extension_host_type_) {
       case VIEW_TYPE_EXTENSION_INFOBAR:
         InsertInfobarCSS();
         break;
       default:
         break;  // No style sheet for other types, at the moment.
     }
   }
 }
 
+void ExtensionHost::OnMessageAddedToConsole(const base::string16& source,
+                                            const base::string16& message,
+                                            const base::string16& stack_trace,
+                                            int32 line_number,
+                                            logging::LogSeverity level) {
+  if (IsSourceFromAnExtension(source)) {

[Yoyo Zhou, 2013/08/23 22:54:54]

Do we still want this test here? I'm thinking about event_bindings errors which
would fail IsSourceFromExtension.

[Devlin, 2013/08/23 23:44:30]

While that's true, the bigger problem is that they'd also fail
ChromeContentRendererClient::ShouldReportDetailedMessageForSource(), since it
uses the same test.  We also don't want to report all errors (regardless of if
they're from an extension or not) to the error console.

I think it's okay for now, and I've already started work on another CL which
expands the test to allow other specific sources (like event_bindings,
schemaUtil, etc).

[Yoyo Zhou, 2013/08/23 23:55:04]

Ok. I was thinking we'd only get extension errors from an ExtensionHost, but
that might not necessarily be true.

+    ErrorConsole::Get(profile_)->ReportError(
+        scoped_ptr<const ExtensionError>(new JavascriptRuntimeError(
+            profile_->IsOffTheRecord(),
+            source,
+            message,
+            stack_trace,
+            line_number,
+            associated_web_contents_ ?
+                associated_web_contents_->GetLastCommittedURL() :
+                GURL::EmptyGURL(),
+            level)));
+  }
+}
+
 void ExtensionHost::CloseContents(WebContents* contents) {
   // TODO(mpcomplete): is this check really necessary?
   if (extension_host_type_ == VIEW_TYPE_EXTENSION_POPUP ||
       extension_host_type_ == VIEW_TYPE_EXTENSION_DIALOG ||
       extension_host_type_ == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE ||
       extension_host_type_ == VIEW_TYPE_EXTENSION_INFOBAR ||
       extension_host_type_ == VIEW_TYPE_PANEL) {
     Close();
   }
 }
@@ skipping 204 matching lines @@
 
 void ExtensionHost::RequestMediaAccessPermission(
     content::WebContents* web_contents,
     const content::MediaStreamRequest& request,
     const content::MediaResponseCallback& callback) {
   MediaCaptureDevicesDispatcher::GetInstance()->ProcessMediaAccessRequest(
       web_contents, request, callback, extension());
 }
 
 }  // namespace extensions