net/spdy/hpack/hpack_decoder.h - Issue 2300683002: Increase maximum size of the HPACK decoder dynamic table to 64 kB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/hpack/hpack_decoder.h

Issue 2300683002: Increase maximum size of the HPACK decoder dynamic table to 64 kB. (Closed)

Patch Set: Update Cronet Android tests. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/hpack/hpack_decoder.h

diff --git a/net/spdy/hpack/hpack_decoder.h b/net/spdy/hpack/hpack_decoder.h

index caad941578783c953f948fb8575c3a377892d49a..172892ffa509cab312d40b5a88744f61952bdb5e 100644

--- a/net/spdy/hpack/hpack_decoder.h

+++ b/net/spdy/hpack/hpack_decoder.h

@@ -38,7 +38,7 @@ class NET_EXPORT_PRIVATE HpackDecoder : public HpackDecoderInterface {

HpackDecoder();

~HpackDecoder() override;

- // Called upon acknowledgement of SETTINGS_HEADER_TABLE_SIZE.

+ // Called upon sending a SETTINGS_HEADER_TABLE_SIZE value.

void ApplyHeaderTableSizeSetting(size_t size_setting) override;

// If a SpdyHeadersHandlerInterface is provided, HpackDecoder will emit