Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2300653002: [tools/perf] Update code to reference py_utils.cloud_storage (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Update code to reference py_utils.cloud_storage BUG=See https://github.com/catapult-project/catapult/issues/2738 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/b26ed69ce61aa6a2f62e221387b40057f6ee70d4 Cr-Commit-Position: refs/heads/master@{#415805}

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -40 lines) Patch
M chrome/test/android/telemetry_tests/PRESUBMIT.py View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/telemetry_tests/browser_tests/popular_urls.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/PRESUBMIT.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/cloud_storage_test_base.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/path_util.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/PRESUBMIT.py View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M tools/auto_bisect/fetch_build.py View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tools/perf/PRESUBMIT.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tools/perf/core/path_util.py View 2 chunks +5 lines, -8 lines 0 comments Download
M tools/perf/fetch_benchmark_deps.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/fetch_benchmark_deps_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/pregenerated_profile_shared_state.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/extension_profile_extender.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/update_remote_extensions.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (21 generated)
nednguyen
4 years, 3 months ago (2016-08-31 15:54:12 UTC) #4
eakuefner
lgtm
4 years, 3 months ago (2016-08-31 16:32:07 UTC) #5
aiolos (Not reviewing)
lgtm
4 years, 3 months ago (2016-08-31 16:36:29 UTC) #6
nednguyen
+kbr for changes to content/test/gpu +jbudorick for changes to chrome/test/android
4 years, 3 months ago (2016-08-31 18:23:20 UTC) #13
nednguyen
4 years, 3 months ago (2016-08-31 18:28:59 UTC) #19
Ken Russell (switch to Gerrit)
lgtm
4 years, 3 months ago (2016-08-31 18:41:08 UTC) #20
jbudorick
chrome/test/android/ lgtm
4 years, 3 months ago (2016-08-31 18:42:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300653002/40001
4 years, 3 months ago (2016-08-31 18:45:14 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/250446)
4 years, 3 months ago (2016-08-31 18:54:00 UTC) #27
nednguyen(REVIEW IN OTHER ACC)
+Prasad for tools/auto_bisect
4 years, 3 months ago (2016-08-31 19:59:50 UTC) #29
prasadv
lgtm
4 years, 3 months ago (2016-08-31 20:45:46 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300653002/40001
4 years, 3 months ago (2016-08-31 23:38:04 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 23:48:17 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 23:51:02 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b26ed69ce61aa6a2f62e221387b40057f6ee70d4
Cr-Commit-Position: refs/heads/master@{#415805}

Powered by Google App Engine
This is Rietveld 408576698