Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2300643003: Add undocumented Memory.* histograms to histograms.xml. (Closed)

Created:
4 years, 3 months ago by Alexei Svitkine (slow)
Modified:
4 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add undocumented Memory.* histograms to histograms.xml. Makes them owned by the same people that own other Memory.* histograms. Also, adds a summary for a TBD histogram and adds units to process count histograms. BUG=642626 Committed: https://crrev.com/792954ab4f88e8c4881a6f686aedb7de4d4bf1f6 Cr-Commit-Position: refs/heads/master@{#415736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M tools/metrics/histograms/histograms.xml View 10 chunks +40 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Alexei Svitkine (slow)
4 years, 3 months ago (2016-08-31 17:24:13 UTC) #3
Ilya Sherman
LGTM, thanks.
4 years, 3 months ago (2016-08-31 19:07:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300643003/20001
4 years, 3 months ago (2016-08-31 19:08:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-31 20:14:23 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:17:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/792954ab4f88e8c4881a6f686aedb7de4d4bf1f6
Cr-Commit-Position: refs/heads/master@{#415736}

Powered by Google App Engine
This is Rietveld 408576698