Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8054)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Issue 2300633006: MD Settings: Search Engine: Call iron-list notifyResize (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
index d8c7b6fc81a3be89ec9f1e4d9a226cb29f46e388..4250af2e811ffbf34db7e3d3ef0405dc9e60de6d 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
@@ -15,19 +15,25 @@ Polymer({
/** @type {!Array<!SearchEngine>} */
defaultEngines: {
type: Array,
- value: function() { return []; }
+ value: function() {
+ return [];
+ },
},
/** @type {!Array<!SearchEngine>} */
otherEngines: {
type: Array,
- value: function() { return []; }
+ value: function() {
+ return [];
+ },
},
/** @type {!Array<!SearchEngine>} */
extensions: {
type: Array,
- value: function() { return []; }
+ value: function() {
+ return [];
+ },
},
/** @private {boolean} */
@@ -40,14 +46,23 @@ Polymer({
}
},
+ observers: ['extensionsChanged_(extensions, showExtensionsList_)'],
+
/** @override */
ready: function() {
- settings.SearchEnginesBrowserProxyImpl.getInstance().
- getSearchEnginesList().then(this.enginesChanged_.bind(this));
+ settings.SearchEnginesBrowserProxyImpl.getInstance()
+ .getSearchEnginesList()
dschuyler 2016/09/01 23:21:50 nit: How about moving this line up with the line a
+ .then(this.enginesChanged_.bind(this));
this.addWebUIListener(
'search-engines-changed', this.enginesChanged_.bind(this));
},
+ /** @private */
+ extensionsChanged_: function() {
+ if (this.showExtensionsList_)
+ this.$.extensions.notifyResize();
+ },
+
/**
* @param {!SearchEnginesInfo} searchEnginesInfo
* @private

Powered by Google App Engine
This is Rietveld 408576698