MD Settings: Search Engine: Call iron-list notifyResize

MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to observe when the list contents change.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069
Cr-Commit-Position: refs/heads/master@{#416767}

[stevenjb, 2016-09-01 17:59:52]

Description was changed from

==========
MD WebUI: Call notifyResize when iron-list contents change

In order to update promptly, iron-list needs to be notified
when either its contents may have changed, or its visibility
changed. This CL fixes a few bugs related to that behavior.

BUG=642661
==========

to

==========
MD WebUI: Call notifyResize when iron-list contents change

In order to update promptly, iron-list needs to be notified
when either its contents may have changed, or its visibility
changed. This CL fixes a few bugs related to that behavior.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-09-01 18:03:12]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org, michaelpg@chromium.org

[michaelpg, 2016-09-01 21:50:04]

> In order to update promptly, iron-list needs to be notified
> when either its contents may have changed

I haven't looked at iron-list in a while, but do we really have to call
notifyResize manually just because items changed?

Seems like the problem is we fail to trigger iron-resize events when a resize
happens (e.g. when opening the Search Engines section). In that case, calling
notifyResize every time the items change seems like a hack which I'm not even
sure is guaranteed to work...

[stevenjb, 2016-09-01 22:48:57]

On 2016/09/01 21:50:04, michaelpg wrote:
> > In order to update promptly, iron-list needs to be notified
> > when either its contents may have changed
> 
> I haven't looked at iron-list in a while, but do we really have to call
> notifyResize manually just because items changed?
> 
> Seems like the problem is we fail to trigger iron-resize events when a resize
> happens (e.g. when opening the Search Engines section). In that case, calling
> notifyResize every time the items change seems like a hack which I'm not even
> sure is guaranteed to work...

So there are two problems with iron-list:
a) There does not seem to be a good mechanism for it to know when it has
actually been stamped, thus the hack in CrScrollableBehavior using
setInterval().
b) Left to its own devices it will update (very) lazily if we don't call
notifyResize, with a visual effect of seeing only one item for ~.5s. Arguably
this is poor behavior in iron-list, but we're kind of past looking into that at
this point.

This works...

[dschuyler, 2016-09-01 23:21:50]

May we get comments in the code about this workaround.
It could be something short that refers out to a Polymer issue URL or 
maybe back to the discussion on this CL.

https://codereview.chromium.org/2300633006/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/2300633006/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:54:
.getSearchEnginesList()
nit: How about moving this line up with the line above
(It looks like they may fit).

[Dan Beam, 2016-09-02 00:41:11]

https://codereview.chromium.org/2300633006/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/2300633006/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:73:
this.extensions = searchEnginesInfo['extensions'];
doesn't this already accomplish what you're doing with notifyResize()?  directly
resetting this.extensions?

[Dan Beam, 2016-09-02 00:42:19]

https://codereview.chromium.org/2300633006/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_page.js
(right):

https://codereview.chromium.org/2300633006/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_page.js:73:
this.extensions = searchEnginesInfo['extensions'];
On 2016/09/02 00:41:11, Dan Beam wrote:
> doesn't this already accomplish what you're doing with notifyResize()? 
directly
> resetting this.extensions?

oh, nevermind, this is when the list is unhidden.  ignore me

[stevenjb, 2016-09-06 18:12:26]

Description was changed from

==========
MD WebUI: Call notifyResize when iron-list contents change

In order to update promptly, iron-list needs to be notified
when either its contents may have changed, or its visibility
changed. This CL fixes a few bugs related to that behavior.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to
observe when the list contents change.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-09-06 18:12:59]

PTAL

[stevenjb, 2016-09-06 18:26:49]

Patchset #3 (id:40001) has been deleted

[dschuyler, 2016-09-06 18:40:22]

lgtm

[stevenjb, 2016-09-06 20:14:28]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:15:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:34:42]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[stevenjb, 2016-09-06 20:55:44]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-09-06 20:55:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2300633006/#ps80001
(title: "Fix closure")

[commit-bot: I haz the power, 2016-09-06 20:56:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-09-06 22:25:31]

michaelpg@chromium.org changed reviewers:
- michaelpg@chromium.org

[commit-bot: I haz the power, 2016-09-06 23:25:03]

Description was changed from

==========
MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to
observe when the list contents change.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to
observe when the list contents change.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-06 23:25:05]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-06 23:30:44]

Description was changed from

==========
MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to
observe when the list contents change.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to
observe when the list contents change.

BUG=642661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069
Cr-Commit-Position: refs/heads/master@{#416767}
==========

[commit-bot: I haz the power, 2016-09-06 23:30:45]

Patchset 4 (id:??) landed as
https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069
Cr-Commit-Position: refs/heads/master@{#416767}