Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2300633005: DevTools: Remove leading newline on scripts immediately (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, flandy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove leading newline on scripts immediately The elements panel was waiting for DOMSyntaxHighligher to strip the leading newline from script tags, which made testing flaky. BUG=623802 Committed: https://crrev.com/3eda8caca348d8c2c2f72d28af48e0757f83d1f2 Cr-Commit-Position: refs/heads/master@{#417052}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/DOMSyntaxHighlighter.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 3 months ago (2016-09-01 01:57:49 UTC) #4
pfeldman
lgtm
4 years, 3 months ago (2016-09-07 18:38:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300633005/20001
4 years, 3 months ago (2016-09-07 18:39:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 21:43:19 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:44:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3eda8caca348d8c2c2f72d28af48e0757f83d1f2
Cr-Commit-Position: refs/heads/master@{#417052}

Powered by Google App Engine
This is Rietveld 408576698