Chromium Code Reviews

Unified Diff: gclient_utils.py

Issue 2300633002: Make use of CheckCallAndFilter42 for gclient's git fetch. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « gclient_scm.py ('k') | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index 4094adf341e5e741e4f110ee282e7016e9f83b52..93c0a7e46cba08364401c9d6cc995fc9f212f153 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -712,7 +712,9 @@ def CheckCallAndFilter42(args, stdout=None, filter_fn=None,
debug_child_info)
time.sleep(sleep_interval)
sleep_interval *= 2
- raise subprocess42.CalledProcessError(
+ # TODO(tandrii): change this to subprocess.CalledProcessError,
+ # beacuse subprocess42 doesn't have a class unlike subprocess2.
+ raise subprocess2.CalledProcessError(
rv, args, kwargs.get('cwd', None), None, None)
« no previous file with comments | « gclient_scm.py ('k') | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine