gm/imagemagnifier.cpp - Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/imagemagnifier.cpp

Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'. (Closed)

Patch Set: small msvc concession Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/imagemagnifier.cpp

diff --git a/gm/imagemagnifier.cpp b/gm/imagemagnifier.cpp

index a012a9e39693095a3ea6e1b6606cfbdb1d0e2a1c..88a6d10d9639ca9571c49680cf1418ab727cefaa 100644

--- a/gm/imagemagnifier.cpp

+++ b/gm/imagemagnifier.cpp

@@ -72,7 +72,7 @@ DEF_SIMPLE_GM_BG(imagemagnifier_cropped, canvas, WIDTH_HEIGHT, WIDTH_HEIGHT, SK_

SkIntToScalar(WIDTH_HEIGHT-32));

srcRect.inset(64.0f, 64.0f);

- static const SkScalar kInset = 64.0f;

+ constexpr SkScalar kInset = 64.0f;

// Crop out a 16 pixel ring around the result

const SkRect rect = SkRect::MakeXYWH(16, 16, WIDTH_HEIGHT-32, WIDTH_HEIGHT-32);

« no previous file with comments | « gm/imagefromyuvtextures.cpp ('k') | gm/imagescalealigned.cpp » ('j') | no next file with comments »