gm/glyph_pos.cpp - Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/glyph_pos.cpp

Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'. (Closed)

Patch Set: small msvc concession Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/glyph_pos.cpp

diff --git a/gm/glyph_pos.cpp b/gm/glyph_pos.cpp

index ed61c7634b008c0aa0c140b1e4190ff3cdfabd4e..7628fbe2983eeedcf879e5f803820c9251257c34 100644

--- a/gm/glyph_pos.cpp

+++ b/gm/glyph_pos.cpp

@@ -14,8 +14,8 @@

* glyph_pos_(h/n)_(s/f/b)

* -> test hairline/non-hairline stroke/fill/stroke+fill.

-static const SkScalar kTextHeight = 14.0f;

-static const char kText[] = "Proportional Hamburgefons #% fi";

+constexpr SkScalar kTextHeight = 14.0f;

+constexpr char kText[] = "Proportional Hamburgefons #% fi";

static void drawTestCase(SkCanvas* canvas,

SkScalar textScale,

« no previous file with comments | « gm/gammacolorfilter.cpp ('k') | gm/glyph_pos_align.cpp » ('j') | no next file with comments »