gm/dashcircle.cpp - Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/dashcircle.cpp

Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'. (Closed)

Patch Set: small msvc concession Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/dashcircle.cpp

diff --git a/gm/dashcircle.cpp b/gm/dashcircle.cpp

index f631c4047694dcc01d9af0b8885a219b8f47054a..fbe08b7bbe478b34d91b57e8263b65dbf7067813 100644

--- a/gm/dashcircle.cpp

+++ b/gm/dashcircle.cpp

@@ -95,7 +95,7 @@ protected:

}

bool onAnimate(const SkAnimTimer& timer) override {

- static const SkScalar kDesiredDurationSecs = 100.0f;

+ constexpr SkScalar kDesiredDurationSecs = 100.0f;

fRotation = timer.scaled(360.0f/kDesiredDurationSecs, 360.0f);

return true;

« no previous file with comments | « gm/cubicpaths.cpp ('k') | gm/dashing.cpp » ('j') | no next file with comments »