gm/bitmappremul.cpp - Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/bitmappremul.cpp

Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'. (Closed)

Patch Set: small msvc concession Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/bitmappremul.cpp

diff --git a/gm/bitmappremul.cpp b/gm/bitmappremul.cpp

index 172612ddb09f7d16463d92886ea5329a732353e1..31a565018da6c9187b40c7772549cb293f7dee7c 100644

--- a/gm/bitmappremul.cpp

+++ b/gm/bitmappremul.cpp

@@ -18,9 +18,9 @@

* This tests both the ARGB4444 and ARGB8888 bitmap configurations.

-static const int SLIDE_SIZE = 256;

-static const int PIXEL_SIZE_8888 = SLIDE_SIZE / 256;

-static const int PIXEL_SIZE_4444 = SLIDE_SIZE / 16;

+constexpr int SLIDE_SIZE = 256;

+constexpr int PIXEL_SIZE_8888 = SLIDE_SIZE / 256;

+constexpr int PIXEL_SIZE_4444 = SLIDE_SIZE / 16;

static void init_bitmap(SkColorType ct, SkBitmap* bitmap) {

bitmap->allocPixels(SkImageInfo::Make(SLIDE_SIZE, SLIDE_SIZE, ct,

« no previous file with comments | « gm/bitmapcopy.cpp ('k') | gm/bitmaprect.cpp » ('j') | no next file with comments »