Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: gm/bmpfilterqualityrepeat.cpp

Issue 2300623005: Replace a lot of 'static const' with 'constexpr' or 'const'. (Closed)
Patch Set: small msvc concession Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/blurs.cpp ('k') | gm/circulararcs.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "gm.h" 8 #include "gm.h"
9 9
10 #include "SkShader.h" 10 #include "SkShader.h"
(...skipping 21 matching lines...) Expand all
32 colorBmp.eraseColor(sk_tool_utils::color_to_565(0xFF2000FF)); 32 colorBmp.eraseColor(sk_tool_utils::color_to_565(0xFF2000FF));
33 canvas.drawBitmap(colorBmp, 20, 20); 33 canvas.drawBitmap(colorBmp, 20, 20);
34 } 34 }
35 35
36 SkString onShortName() override { return SkString("bmp_filter_quality_repeat "); } 36 SkString onShortName() override { return SkString("bmp_filter_quality_repeat "); }
37 37
38 SkISize onISize() override { return SkISize::Make(1000, 235); } 38 SkISize onISize() override { return SkISize::Make(1000, 235); }
39 39
40 void onDraw(SkCanvas* canvas) override { 40 void onDraw(SkCanvas* canvas) override {
41 41
42 static const struct { 42 constexpr struct {
43 SkFilterQuality fQuality; 43 SkFilterQuality fQuality;
44 const char* fName; 44 const char* fName;
45 } kQualities[] = { 45 } kQualities[] = {
46 {kNone_SkFilterQuality, "none"}, 46 {kNone_SkFilterQuality, "none"},
47 {kLow_SkFilterQuality, "low"}, 47 {kLow_SkFilterQuality, "low"},
48 {kMedium_SkFilterQuality, "medium"}, 48 {kMedium_SkFilterQuality, "medium"},
49 {kHigh_SkFilterQuality, "high"}, 49 {kHigh_SkFilterQuality, "high"},
50 }; 50 };
51 51
52 for (size_t q = 0; q < SK_ARRAY_COUNT(kQualities); ++q) { 52 for (size_t q = 0; q < SK_ARRAY_COUNT(kQualities); ++q) {
53 SkPaint paint; 53 SkPaint paint;
54 sk_tool_utils::set_portable_typeface(&paint); 54 sk_tool_utils::set_portable_typeface(&paint);
55 paint.setFilterQuality(kQualities[q].fQuality); 55 paint.setFilterQuality(kQualities[q].fQuality);
56 SkPaint bmpPaint(paint); 56 SkPaint bmpPaint(paint);
57 SkMatrix lm = SkMatrix::I(); 57 SkMatrix lm = SkMatrix::I();
58 lm.setScaleX(2.5); 58 lm.setScaleX(2.5);
59 lm.setTranslateX(423); 59 lm.setTranslateX(423);
60 lm.setTranslateY(330); 60 lm.setTranslateY(330);
61 61
62 static const SkShader::TileMode kTM = SkShader::kRepeat_TileMode; 62 constexpr SkShader::TileMode kTM = SkShader::kRepeat_TileMode;
63 bmpPaint.setShader(SkShader::MakeBitmapShader(fBmp, kTM, kTM, &lm)); 63 bmpPaint.setShader(SkShader::MakeBitmapShader(fBmp, kTM, kTM, &lm));
64 SkRect rect = SkRect::MakeLTRB(20, 60, 220, 210); 64 SkRect rect = SkRect::MakeLTRB(20, 60, 220, 210);
65 canvas->drawRect(rect, bmpPaint); 65 canvas->drawRect(rect, bmpPaint);
66 paint.setAntiAlias(true); 66 paint.setAntiAlias(true);
67 canvas->drawText(kQualities[q].fName, strlen(kQualities[q].fName), 2 0, 40, paint); 67 canvas->drawText(kQualities[q].fName, strlen(kQualities[q].fName), 2 0, 40, paint);
68 canvas->translate(250, 0); 68 canvas->translate(250, 0);
69 } 69 }
70 } 70 }
71 71
72 private: 72 private:
73 SkBitmap fBmp; 73 SkBitmap fBmp;
74 74
75 typedef skiagm::GM INHERITED; 75 typedef skiagm::GM INHERITED;
76 }; 76 };
77 77
78 ////////////////////////////////////////////////////////////////////////////// 78 //////////////////////////////////////////////////////////////////////////////
79 79
80 DEF_GM(return new BmpFilterQualityRepeat;) 80 DEF_GM(return new BmpFilterQualityRepeat;)
OLDNEW
« no previous file with comments | « gm/blurs.cpp ('k') | gm/circulararcs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698