Make tests wait until automation is done to prevent leaks

Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
Committed: https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf
Cr-Commit-Position: refs/heads/master@{#416025}

[Navid Zolghadr, 2016-09-01 16:06:25]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 16:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-01 16:12:04]

Description was changed from

==========
Make a test that waits until automation is done

Adding a supet test that wait on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

to

==========
Make tests wait until automation is done to prevent leaks

Adding a supet test that wait on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

[Navid Zolghadr, 2016-09-01 16:12:29]

nzolghadr@chromium.org changed reviewers:
+ dtapuska@chromium.org, tdresser@chromium.org

[dtapuska, 2016-09-01 16:55:49]

lgtm % Is supet a word? Sounds like the commit msg needs a little editing

[Navid Zolghadr, 2016-09-01 17:01:07]

Description was changed from

==========
Make tests wait until automation is done to prevent leaks

Adding a supet test that wait on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

to

==========
Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

[tdresser, 2016-09-01 17:05:57]

We still need .'s at the end of comments in js, don't we?

There appear to be lots missing.

LGTM with nits.

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js
(right):

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js:9:
// To handle delayed capturing
Missing .

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
(right):

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:7:
// Mouse actions
.

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:62:
function mouseDragInTarget(targetId) {
Can this be defined in terms of mouseDragInTargets?

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:237:
// Defined in every test and should return a promise that gets resolved when
input is finished
.

[commit-bot: I haz the power, 2016-09-01 17:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:15:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Navid Zolghadr, 2016-09-01 17:55:12]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:55:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-01 18:21:53]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 18:22:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-01 18:58:07]

I added all the missing dots everywhere else as well.

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js
(right):

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js:9:
// To handle delayed capturing
On 2016/09/01 17:05:57, tdresser wrote:
> Missing .

Done.

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
(right):

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:7:
// Mouse actions
On 2016/09/01 17:05:57, tdresser wrote:
> .

Done.

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:62:
function mouseDragInTarget(targetId) {
On 2016/09/01 17:05:57, tdresser wrote:
> Can this be defined in terms of mouseDragInTargets?

Done.

https://codereview.chromium.org/2300623004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:237:
// Defined in every test and should return a promise that gets resolved when
input is finished
On 2016/09/01 17:05:57, tdresser wrote:
> .

Done.

[Navid Zolghadr, 2016-09-01 19:45:06]

The CQ bit was unchecked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-09-01 19:45:15]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-09-01 19:45:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2300623004/#ps40001
(title: "Fix test expectation")

[commit-bot: I haz the power, 2016-09-01 19:46:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 19:52:08]

Description was changed from

==========
Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

to

==========
Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

[commit-bot: I haz the power, 2016-09-01 19:52:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 19:54:13]

Description was changed from

==========
Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060
==========

to

==========
Make tests wait until automation is done to prevent leaks

Adding an umbrella test that waits on the promise returned
by inject_input method so that it makes sure the input
automation is done before the whole test passes and
finishes the test. This prevent the leak that was
happening before as the result of closing the test
early.

BUG=619060

Committed: https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf
Cr-Commit-Position: refs/heads/master@{#416025}
==========

[commit-bot: I haz the power, 2016-09-01 19:54:14]

Patchset 3 (id:??) landed as
https://crrev.com/62234589a64896729acb4a53c874e775aefb3daf
Cr-Commit-Position: refs/heads/master@{#416025}