|
|
Chromium Code Reviews
DescriptionManually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits).
This also update test_runner.pydeps to include changes to references to
catapult_base directory.
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/578e20909005..fa2c4f21907f
$ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 benjhayden Rename Histogram.add() to addSample().
2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test.
2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation
2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ )
2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries.
2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names
2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/
2016-08-30 washingtonp Pass in custom options to Systrace agents
2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM
2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll.
2016-08-30 fmeawad v8CallStats: Update the arg name
2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms.
2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/
BUG=638124, 642716
TBR=catapult-sheriff@chromium.org
patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1)
Committed: https://crrev.com/e7bab67cfdc033f59e2742357779ad34fe3182c7
Cr-Commit-Position: refs/heads/master@{#415625}
Patch Set 1 #Patch Set 2 : update #
Total comments: 2
Patch Set 3 : Remove ^M #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ========== to ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ==========
nednguyen@google.com changed reviewers: + jbudorick@chromium.org, rnephew@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ========== to ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ==========
build/android/ lgtm w/ nit https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... File build/android/test_runner.pydeps (right): https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... build/android/test_runner.pydeps:2: # build/print_python_deps.py --root 'build/android' --output 'build/android/test_runner.pydeps' 'build/android/test_runner.py' nit: why are the arguments quoted now...?
https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... File build/android/test_runner.pydeps (right): https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... build/android/test_runner.pydeps:2: # build/print_python_deps.py --root 'build/android' --output 'build/android/test_runner.pydeps' 'build/android/test_runner.py' On 2016/08/31 13:05:31, jbudorick wrote: > nit: why are the arguments quoted now...? I am not sure. Maybe because I run this on on my windows machine?
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/31 13:06:44, nednguyen wrote: > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... > File build/android/test_runner.pydeps (right): > > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... > build/android/test_runner.pydeps:2: # build/print_python_deps.py --root > 'build/android' --output 'build/android/test_runner.pydeps' > 'build/android/test_runner.py' > On 2016/08/31 13:05:31, jbudorick wrote: > > nit: why are the arguments quoted now...? > > I am not sure. Maybe because I run this on on my windows machine? That could be. I'm a little concerned that presubmits on linux are going to complain about this once this lands...
On 2016/08/31 13:08:02, jbudorick wrote: > On 2016/08/31 13:06:44, nednguyen wrote: > > > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... > > File build/android/test_runner.pydeps (right): > > > > > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runn... > > build/android/test_runner.pydeps:2: # build/print_python_deps.py --root > > 'build/android' --output 'build/android/test_runner.pydeps' > > 'build/android/test_runner.py' > > On 2016/08/31 13:05:31, jbudorick wrote: > > > nit: why are the arguments quoted now...? > > > > I am not sure. Maybe because I run this on on my windows machine? > > That could be. I'm a little concerned that presubmits on linux are going to > complain about this once this lands... Looks like PRESBUMIT is green
Message was sent while issue was closed.
Description was changed from ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ========== to ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) ========== to ========== Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapu... $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) Committed: https://crrev.com/e7bab67cfdc033f59e2742357779ad34fe3182c7 Cr-Commit-Position: refs/heads/master@{#415625} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e7bab67cfdc033f59e2742357779ad34fe3182c7 Cr-Commit-Position: refs/heads/master@{#415625} |
