Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2300623002: Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
Reviewers:
jbudorick, rnephew (Reviews Here), catapult-sheriff
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually roll src/third_party/catapult/ 578e20909..fa2c4f219 (13 commits). This also update test_runner.pydeps to include changes to references to catapult_base directory. https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/578e20909005..fa2c4f21907f $ git log 578e20909..fa2c4f219 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Rename Histogram.add() to addSample(). 2016-08-30 benjhayden Replace ScalarNumerics with Histograms in value_set_test and value_set_table_test. 2016-08-30 ksakamoto Update FirstMeaningfulPaint to use Blink's implementation 2016-08-30 aiolos Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) 2016-08-30 benjhayden Refactor NumericBuilder to HistogramBinBoundaries. 2016-08-30 fmeawad v8CallStats: Add a map between URL and known domain names 2016-08-30 eakuefner [Catapult] Update .gitignore to point to new locations in common/ 2016-08-30 washingtonp Pass in custom options to Systrace agents 2016-08-30 nednguyen [telemetry] Only disable trace profiler for TBM 2016-08-30 jbudorick [devil] Re-add the reset_usb import to unblock the catapult roll. 2016-08-30 fmeawad v8CallStats: Update the arg name 2016-08-30 benjhayden Migrate memoryMetric from ScalarNumerics to Histograms. 2016-08-30 nednguyen Remove catapult_base/ and move its files to common/py_utils/ BUG=638124, 642716 TBR=catapult-sheriff@chromium.org patch from issue 2298183003 at patchset 1 (http://crrev.com/2298183003#ps1) Committed: https://crrev.com/e7bab67cfdc033f59e2742357779ad34fe3182c7 Cr-Commit-Position: refs/heads/master@{#415625}

Patch Set 1 #

Patch Set 2 : update #

Total comments: 2

Patch Set 3 : Remove ^M #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/test_runner.pydeps View 1 2 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
nednguyen
4 years, 3 months ago (2016-08-31 12:59:23 UTC) #3
jbudorick
build/android/ lgtm w/ nit https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps File build/android/test_runner.pydeps (right): https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps#newcode2 build/android/test_runner.pydeps:2: # build/print_python_deps.py --root 'build/android' --output ...
4 years, 3 months ago (2016-08-31 13:05:31 UTC) #7
nednguyen
https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps File build/android/test_runner.pydeps (right): https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps#newcode2 build/android/test_runner.pydeps:2: # build/print_python_deps.py --root 'build/android' --output 'build/android/test_runner.pydeps' 'build/android/test_runner.py' On 2016/08/31 ...
4 years, 3 months ago (2016-08-31 13:06:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300623002/40001
4 years, 3 months ago (2016-08-31 13:07:03 UTC) #10
jbudorick
On 2016/08/31 13:06:44, nednguyen wrote: > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps > File build/android/test_runner.pydeps (right): > > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps#newcode2 > ...
4 years, 3 months ago (2016-08-31 13:08:02 UTC) #11
nednguyen
On 2016/08/31 13:08:02, jbudorick wrote: > On 2016/08/31 13:06:44, nednguyen wrote: > > > https://codereview.chromium.org/2300623002/diff/20001/build/android/test_runner.pydeps ...
4 years, 3 months ago (2016-08-31 13:12:51 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 14:12:01 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 14:14:10 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7bab67cfdc033f59e2742357779ad34fe3182c7
Cr-Commit-Position: refs/heads/master@{#415625}

Powered by Google App Engine
This is Rietveld 408576698