Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2300613002: Revert of [BotHealth] Disable v8.infinite_scroll benchmarks on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import re 5 import re
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 super(V8TodoMVCIgnition, self).SetExtraBrowserOptions(options) 144 super(V8TodoMVCIgnition, self).SetExtraBrowserOptions(options)
145 v8_helper.EnableIgnition(options) 145 v8_helper.EnableIgnition(options)
146 146
147 @classmethod 147 @classmethod
148 def Name(cls): 148 def Name(cls):
149 return 'v8.todomvc-ignition' 149 return 'v8.todomvc-ignition'
150 150
151 151
152 # Disabled on reference builds because they don't support the new 152 # Disabled on reference builds because they don't support the new
153 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022. 153 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
154 # Windows: crbug.com/638724 154 @benchmark.Disabled('reference')
155 @benchmark.Disabled('win', 'reference')
156 class V8InfiniteScroll(_InfiniteScrollBenchmark): 155 class V8InfiniteScroll(_InfiniteScrollBenchmark):
157 """Measures V8 GC metrics and memory usage while scrolling the top web pages. 156 """Measures V8 GC metrics and memory usage while scrolling the top web pages.
158 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 157 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
159 158
160 page_set = page_sets.InfiniteScrollPageSet 159 page_set = page_sets.InfiniteScrollPageSet
161 160
162 @classmethod 161 @classmethod
163 def Name(cls): 162 def Name(cls):
164 return 'v8.infinite_scroll_tbmv2' 163 return 'v8.infinite_scroll_tbmv2'
165 164
166 165
167 # Disabled on reference builds because they don't support the new 166 # Disabled on reference builds because they don't support the new
168 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022. 167 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
169 # Windows: crbug.com/638724 168 @benchmark.Disabled('reference') # crbug.com/579546
170 @benchmark.Disabled('win', 'reference') # crbug.com/579546
171 class V8InfiniteScrollIgnition(V8InfiniteScroll): 169 class V8InfiniteScrollIgnition(V8InfiniteScroll):
172 """Measures V8 GC metrics using Ignition.""" 170 """Measures V8 GC metrics using Ignition."""
173 171
174 def SetExtraBrowserOptions(self, options): 172 def SetExtraBrowserOptions(self, options):
175 super(V8InfiniteScrollIgnition, self).SetExtraBrowserOptions(options) 173 super(V8InfiniteScrollIgnition, self).SetExtraBrowserOptions(options)
176 v8_helper.EnableIgnition(options) 174 v8_helper.EnableIgnition(options)
177 175
178 @classmethod 176 @classmethod
179 def Name(cls): 177 def Name(cls):
180 return 'v8.infinite_scroll-ignition_tbmv2' 178 return 'v8.infinite_scroll-ignition_tbmv2'
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 return True 297 return True
300 # http://crbug.com/623576 298 # http://crbug.com/623576
301 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or 299 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
302 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'): 300 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
303 return True 301 return True
304 return False 302 return False
305 303
306 @classmethod 304 @classmethod
307 def ShouldTearDownStateAfterEachStoryRun(cls): 305 def ShouldTearDownStateAfterEachStoryRun(cls):
308 return True 306 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698