third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html - Issue 2300523002: DevTools: cleanup WI.CSSWorkspaceBindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html

Issue 2300523002: DevTools: cleanup WI.CSSWorkspaceBindings (Closed)

Patch Set: address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html ('k') | third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html b/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html

index 30ab9f066a1b5d7c9e93b85b533d5b25a3a037fe..fb37fc503496d9a330c308cc0100760ec04fa3bd 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html

@@ -65,11 +65,8 @@ function test()

{

var locationsCount = 0;

var targetInfos = WebInspector.cssWorkspaceBinding._modelToTargetInfo.valuesArray();

- for (var targetInfo of targetInfos) {

- var headerInfos = targetInfo._headerInfoById.valuesArray();

- for (var headerInfo of headerInfos)

- locationsCount += headerInfo._locations.size;

- }

+ for (var targetInfo of targetInfos)

+ locationsCount += targetInfo._locations.valuesArray().length;

return locationsCount;

}