Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

Issue 2300523002: DevTools: cleanup WI.CSSWorkspaceBindings (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
index 9b09f01628d3dbbd55dc6237d72d80af82cf4d7e..1afbf70322426f0fa691606c913eddfc8575f640 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
@@ -30,7 +30,6 @@
/**
* @constructor
- * @implements {WebInspector.CSSSourceMapping}
* @param {!WebInspector.CSSModel} cssModel
* @param {!WebInspector.Workspace} workspace
* @param {!WebInspector.NetworkMapping} networkMapping
@@ -58,7 +57,6 @@ WebInspector.StylesSourceMapping.ChangeUpdateTimeoutMs = 200;
WebInspector.StylesSourceMapping.prototype = {
/**
- * @override
* @param {!WebInspector.CSSLocation} rawLocation
* @return {?WebInspector.UILocation}
*/
@@ -78,46 +76,6 @@ WebInspector.StylesSourceMapping.prototype = {
},
/**
- * @override
- * @param {!WebInspector.UISourceCode} uiSourceCode
- * @param {number} lineNumber
- * @param {number} columnNumber
- * @return {?WebInspector.CSSLocation}
- */
- uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber)
- {
- return null;
- },
-
- /**
- * @override
- * @return {boolean}
- */
- isIdentity: function()
- {
- return true;
- },
-
- /**
- * @override
- * @param {!WebInspector.UISourceCode} uiSourceCode
- * @param {number} lineNumber
- * @return {boolean}
- */
- uiLineHasMapping: function(uiSourceCode, lineNumber)
- {
- return true;
- },
-
- /**
- * @return {!WebInspector.Target}
- */
- target: function()
- {
- return this._cssModel.target();
- },
-
- /**
* @param {!WebInspector.CSSStyleSheetHeader} header
*/
addHeader: function(header)
@@ -126,7 +84,6 @@ WebInspector.StylesSourceMapping.prototype = {
if (!url)
return;
- WebInspector.cssWorkspaceBinding.pushSourceMapping(header, this);
var map = this._urlToHeadersByFrameId.get(url);
if (!map) {
map = /** @type {!Map.<string, !Map.<string, !WebInspector.CSSStyleSheetHeader>>} */ (new Map());
@@ -141,6 +98,7 @@ WebInspector.StylesSourceMapping.prototype = {
var uiSourceCode = this._networkMapping.uiSourceCodeForStyleURL(url, header);
if (uiSourceCode)
this._bindUISourceCode(uiSourceCode, header);
+ WebInspector.cssWorkspaceBinding.updateLocations(header);
dgozman 2016/09/02 19:13:01 Remove.
lushnikov 2016/09/08 00:20:26 Done.
},
/**
@@ -186,7 +144,7 @@ WebInspector.StylesSourceMapping.prototype = {
*/
_unbindAllUISourceCodes: function(event)
{
- if (event.data.target() !== this.target())
+ if (event.data.target() !== this._cssModel.target())
return;
for (var styleFile of this._styleFiles.values())
styleFile.dispose();
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698