Refactor object/class literal property name parsing

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2894 matching lines @@
   const char* statement_data[] = {
     ",",
     // Wrong number of parameters
     "get bar(x) {}",
     "get bar(x, y) {}",
     "set bar() {}",
     "set bar(x, y) {}",
     // Parsing FunctionLiteral for getter or setter fails
     "get foo( +",
     "get foo() \"error\"",
+    // Various forbidden forms
+    "static x: 0",
+    "static x(){}",

[adamk, 2016/08/31 17:37:07]

Please add some tests with async (you'll have to add the
kAllowHarmonyAsyncWhatever flag to the RunParserSyncTest call).

[bakkot, 2016/08/31 19:46:28]

Done.

+    "*x: 0",
+    "*x",
+    "*get x(){}",
+    "*set x(y){}",
+    "get *x(){}",
+    "set *x(y){}",
+    "get x*(){}",
+    "set x*(y){}",
+    "x = 0",
+    "* *x(){}",
+    "x*(){}",
     NULL
   };
 
   RunParserSyncTest(context_data, statement_data, kError);
 }
 
 
 TEST(NoErrorsObjectLiteralChecking) {
   const char* context_data[][2] = {
     {"var myobject = {", "};"},
@@ skipping 36 matching lines @@
     "set 1(v) {}",
     // Non-colliding getters and setters -> no errors
     "foo: 1, get bar() {}",
     "foo: 1, set bar(v) {}",
     "\"foo\": 1, get \"bar\"() {}",
     "\"foo\": 1, set \"bar\"(v) {}",
     "1: 1, get 2() {}",
     "1: 1, set 2(v) {}",
     "get: 1, get foo() {}",
     "set: 1, set foo(_) {}",
+    // Potentially confusing cases
+    "*get() {}",
+    "*set() {}",
+    "*static() {}",
+    "get : 0",

[adamk, 2016/08/31 17:37:07]

Maybe some positive async tests too?

[bakkot, 2016/08/31 19:46:28]

Done.

+    "set : 0",
     // Keywords, future reserved and strict future reserved are also allowed as
     // property names.
     "if: 4",
     "interface: 5",
     "super: 6",
     "eval: 7",
     "arguments: 8",
     NULL
   };
 
@@ skipping 5198 matching lines @@
     "(a,);",
     "(a,b,c,);",
     NULL
   };
   // clang-format on
 
   static const ParserFlag always_flags[] = {kAllowHarmonyTrailingCommas};
   RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }